Package: policykit-1-gnome
Version: 0.105-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu quantal ubuntu-patch



*** /tmp/tmpxkPNXr/bug_body
In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/08-fresh-x11-timestamps.patch: use fresh X11 timestamps
    when displaying authentication dialog to circumvent focus-stealing
    prevention. (LP: #946171)

This happens frequently when using metacity. See the following downstream
bug:

https://bugs.launchpad.net/ubuntu/+source/policykit-gnome/+bug/946171

and the Gnome bug:

https://bugzilla.gnome.org/show_bug.cgi?id=676076

Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers precise-updates
  APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500, 
'precise-proposed'), (500, 'precise')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-29-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru policykit-1-gnome-0.105/debian/changelog policykit-1-gnome-0.105/debian/changelog
diff -Nru policykit-1-gnome-0.105/debian/patches/08-fresh-x11-timestamps.patch policykit-1-gnome-0.105/debian/patches/08-fresh-x11-timestamps.patch
--- policykit-1-gnome-0.105/debian/patches/08-fresh-x11-timestamps.patch	1969-12-31 19:00:00.000000000 -0500
+++ policykit-1-gnome-0.105/debian/patches/08-fresh-x11-timestamps.patch	2012-08-08 09:56:17.000000000 -0400
@@ -0,0 +1,28 @@
+Description: use fresh X11 timestamps when displaying authentication dialog
+ to circumvent focus-stealing prevention.
+Author: Jeffrey Knockel <jeff...@gmail.com>
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/policykit-gnome/+bug/946171
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=676076
+
+Index: policykit-1-gnome-0.105/src/polkitgnomeauthenticator.c
+===================================================================
+--- policykit-1-gnome-0.105.orig/src/polkitgnomeauthenticator.c	2012-07-27 00:39:09.000000000 -0600
++++ policykit-1-gnome-0.105/src/polkitgnomeauthenticator.c	2012-07-27 00:40:27.185547436 -0600
+@@ -26,6 +26,7 @@
+ #include <sys/types.h>
+ #include <pwd.h>
+ #include <glib/gi18n.h>
++#include <gdk/gdkx.h>
+ 
+ #include <polkit/polkit.h>
+ #include <polkitagent/polkitagent.h>
+@@ -307,7 +308,8 @@
+     }
+ 
+   gtk_widget_show_all (GTK_WIDGET (authenticator->dialog));
+-  gtk_window_present (GTK_WINDOW (authenticator->dialog));
++  gtk_window_present_with_time (GTK_WINDOW (authenticator->dialog),
++                                gdk_x11_get_server_time (gtk_widget_get_window (GTK_WIDGET (authenticator->dialog))));
+   password = polkit_gnome_authentication_dialog_run_until_response_for_prompt (POLKIT_GNOME_AUTHENTICATION_DIALOG (authenticator->dialog),
+                                                                                modified_request,
+                                                                                echo_on,
diff -Nru policykit-1-gnome-0.105/debian/patches/series policykit-1-gnome-0.105/debian/patches/series
--- policykit-1-gnome-0.105/debian/patches/series	2012-02-10 23:21:49.000000000 -0500
+++ policykit-1-gnome-0.105/debian/patches/series	2012-08-08 09:18:28.000000000 -0400
@@ -4,3 +4,4 @@
 04-autorestart.patch
 06-authentication-failure-string.patch
 07-use-accountsservice.patch
+08-fresh-x11-timestamps.patch

Reply via email to