On 15/07/12 02:10, Barry deFreese wrote:
Package: ptlib
Version: 2.10.4~dfsg-1
Severity: important
User: debian-h...@lists.debian.org
Usertags: hurd
Tags: patch

Hi,

Currently ptlib fails to build on Debian GNU/Hurd.

Attached is a patch for building on Hurd.  It also requires a fix to remove the 
--enable-oss flag
when building on Hurd as we don't have sound support.

Thank you for the patch, I have somme comments before commiting it.

1. Could you please replace the diff for configure by a diff for configure.ac?

2. Do you mind if you mix the two #ifdef (LINUX and P_GNU) in object.h (to have fewer lines)?

3. About oss: in plugins/configure.in I see:

AC_ARG_ENABLE(oss, [ --enable-oss enable OSS audio support],,enable_oss=no)

if test "${enable_oss}z" = "yesz" ; then
  AC_CHECK_HEADER(sys/soundcard.h, OSSSNDCARDHDR=1)
  AC_MSG_CHECKING(for OSS sound support)
  if test "${OSSSNDCARDHDR}z" != "z"; then
    AC_SUBST(HAS_OSS, 1)
    AC_MSG_RESULT(yes)
  else
    AC_MSG_RESULT(no)
  fi
fi

If Hurd does not have sys/soundcard.h, then OSS will automatically be disabled, is that right? So no need of explicitly disabling oss.


Note: I will apply this to current branch, 2.10.7, hope there will be no error.

--
Eugen


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to