Package: memcached
Version: 1.4.13-0.1
Severity: normal
Tags: upstream patch

Dear Maintainer,

This bug was originally reported in Ubuntu:

https://bugs.launchpad.net/ubuntu/+source/memcached/+bug/1005821

it was also forwarded upstream:

http://code.google.com/p/memcached/issues/detail?id=283

--- quoting original bug ---
memcached daemon has an option to specify custom character as the
delimeter between key prefixes and IDs. # character cannot be used because
of limitation of /usr/share/memcached/scripts/start-memcached. This
startup script parses /etc/memcached_*.conf files and treats every line
with # sign as a comment, which is wrong in case of line like below: -D #

Simple patch attached. I know it's not perfect but it works :)
--- end quoting ---

The patch is sound, requiring that # be the *first* non-whitespace
character in the line to be considered a comment.

-- System Information:
Debian Release: wheezy/sid
  APT prefers precise-updates
  APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500, 
'precise'), (100, 'precise-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-27-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- /usr/share/memcached/scripts/start-memcached	2012-04-04 18:49:46.000000000 +0200
+++ start-memcached	2012-05-29 11:13:28.181568485 +0200
@@ -62,7 +62,7 @@
     foreach my $line (<$etchandle>)
     {
         $line ||= "";
-        $line =~ s/\#.*//g;
+        $line =~ s/^\s*\#.*//g;
         $line =~ s/\s+$//g;
         $line =~ s/^\s+//g;
         next unless $line;

Reply via email to