* Julien Cristau:
> On Tue, Jul 17, 2012 at 22:08:00 +0200, Hilko Bengen wrote:
>
>> diff --git a/debian/rules b/debian/rules
>> index fb143c4..1f3c435 100755
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -130,9 +130,9 @@ override_dh_install:
>> # Workaround for python3-defaults < 3.2~b2-1
>> # ("do not rename .so files outside dist-packages directory")
>> override_dh_python3:
>> - dh_python3 -p python-libguestfs
>> + dh_python3 -p python-guestfs
>> override_dh_python2:
>> - dh_python2 -p python-libguestfs -V 2.6-
>> + dh_python2 -p python-guestfs -V 2.6-
>>
>> # Workaround for Lintian warning
>> # "{pre,post}inst-has-useless-call-to-ldconfig"
>>
> Two questions here:
> - why bother working around a bug in python3-defaults < 3.2~b2-1,
> instead of build-depending on a fixed version?
When I introduced those overrides, I was also providing unofficial
squeeze backports and being able to build those from unmodified source
saved a bit of time. With gobject-introspection bindings and multiarch,
this is no longer the case.
I should just remove those.
Would an updated package, with changes over 1:1.18.1-1 as shown in the
attached patch, be acceptable for wheezy?
> - why are the python and python3 modules shipped in the same deb? That
> seems different from every other python3 module I've seen so far.
I don't remember exactly why I did it this way. But there are a few
packages that ship files for both python 2 and 3. I am going to ask
questions on the relevant mailing list about this. This is not relevant
for the release, is it? (Changing this would mean introducing another
binary package.)
Cheers,
-Hilko
diff --git a/debian/changelog b/debian/changelog
index bfdf63e..e4c5c0a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+libguestfs (1:1.18.1-1wheezy1) testing; urgency=low
+
+ * [40d6de2] Remove useless dh_python* overrides (Closes: #681587)
+
+ -- Hilko Bengen <ben...@debian.org> Sat, 21 Jul 2012 16:36:10 +0200
+
libguestfs (1:1.18.1-1) unstable; urgency=low
* New upstream version
diff --git a/debian/rules b/debian/rules
index 6386c1d..f496a8e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -126,13 +126,6 @@ override_dh_install:
erlang-depends -perlang-guestfs
dh_install
-# Workaround for python3-defaults < 3.2~b2-1
-# ("do not rename .so files outside dist-packages directory")
-override_dh_python3:
- dh_python3 -p python-libguestfs
-override_dh_python2:
- dh_python2 -p python-libguestfs -V 2.6-
-
# Workaround for Lintian warning
# "{pre,post}inst-has-useless-call-to-ldconfig"
override_dh_makeshlibs:
git finished.
