Ah, that's some stale debug code that shouldn't have been there. I've also added some logic so that a stale TEMPFILE should be ignored on the basis that mythtv-status either died, or was killed.
I'll push out an new version shortly.
On Sun, 2012-07-15 at 16:09 +0100, Julian Gilbey wrote:
> Package: mythtv-status
> Version: 0.10.1-1
> Tags: patch
>
> I'm getting loads of messages to root saying things along the lines of:
>
> Hey, /var/run/motd.mythtv-status already exists
> -rw-r--r-- 1 root root 355 Jul 15 12:04 /var/run/motd
> -rw-r--r-- 1 root root 355 Jul 15 12:05 /var/run/motd.mythtv-status
> -rw-r--r-- 1 root root 355 Jul 15 12:05 /var/run/motd.orig
> root 14201 14045 0 16:02 pts/3 00:00:00 /bin/sh
> /etc/init.d/mythtv-status reload
> root 14209 14201 0 16:02 pts/3 00:00:00 grep mythtv-status
> cat: /var/run/motd.new: No such file or directory
>
> Is the intention for /etc/init.d/mythtv-status to bomb out when the
> temp file already exists or to keep on going, but just to warn?
>
> If the first, then the /etc/init.d/mythtv-status file should say in
> the block on lines 66-71:
>
> if [ -f $TEMPFILE ]; then
> [...]
> exit 1
> fi
>
> If it is not, then the cat /var/run/motd.new command should be
> protected (line 70) by writing:
>
> cat /var/run/motd.new 1>&2 || true
>
> This way, the script will continue even if the file does not exist
> (which will probably be the case).
>
> (A separate bug: if it is giving a warning, it should probably use the
> log_warning_msg function instead of echo.)
>
> Julian
>
--
Andrew Ruthven
Wellington, New Zealand
At home: and...@etc.gen.nz | linux.conf.au 2013
| Come join the party...
| http://linux.conf.au
signature.asc
Description: This is a digitally signed message part
