Michael Vogt <m...@debian.org> writes:
> I consider the above comments as rather rude.
I apologize for that. Yes, I see that the tone of that comment can be
considered rude. That was really not the intention.
> The tests where run and
> don't fail on my system(s). This maybe locale dependant thought which
> indicates that they are not good enough. But claiming they are not run
> at all and that they are useless is a bit over the top. Plus they test
> that the mail is send (or not) and that it contains the elements
> needed.
This may be just me misunderstanding something, but the "test_mail.py"
script seems to redirect the mail to a file by replacing the mailx binary
with "mock-mail", which just redirects it's input to a file. And I failed
to see how it could succeed as long as "utf-8" != "utf8"
bjorn@canardo:/usr/local/mydebs/tmp/unattended-upgrades-0.79.1$ egrep 'utf-?8'
unattended-upgrade test/test_mail.py
unattended-upgrade: # ensure that the message a utf8 encoded string
unattended-upgrade: s = s.encode("utf-8", "replace")
unattended-upgrade: msg.set_charset("utf8")
test/test_mail.py:# -*- coding: utf-8 -*-
test/test_mail.py: self.assertTrue('Content-Type: text/plain;
charset="utf-8"' in mail_txt)
unless of course, your Message.set_charset does some magic processing of
the input. Which it indeed does in wheezy. That explains it. I did a
(too) quick test on a system running squeeze. My fault.
Sorry about that. And once again my apoligies for the tone. It was
completely unwarranted, and not appropriate at all in any case.
Bjørn
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
