On Tue, Jul 3, 2012 at 23:48:52 -0600, Bdale Garbee wrote: > Package: release.debian.org > Severity: normal > User: release.debian....@packages.debian.org > Usertags: unblock > > Please unblock package gcpegg. This version fixes RC bug #680014 which > affects all 64-bit architectures. It also fixes an unreported path bug > in the init.d script that would affect all users. > > This is *not* an absolutely minimal diff to fix those bugs from -12, but > the package is better in all respects, -13 has received significant testing, > and it's a "leaf package" that nothing else depends on... so I really think > 5.1-13 is the version that should be in wheezy. >
> diff -u gcpegg-5.1/reg_orion.c gcpegg-5.1/reg_orion.c
> --- gcpegg-5.1/reg_orion.c
> +++ gcpegg-5.1/reg_orion.c
> @@ -97,7 +97,7 @@
> sprintf(ttydev, "/dev/term/%c", 'a' + (opts->port - 1));
> #endif
> #else
> - sprintf(ttydev, "/dev/ttyS%d", opts->port);
> + sprintf(ttydev, "/dev/REG", opts->port);
> #endif
>
> switch(opts->baud) {
shouldn't the opts->port argument have been dropped? same in
reg_pear.c, hw_pear.c.
> -
> - strftime(udate, sizeof udate, timeFormat, gmtime((time_t *)
> &now));
> - strftime(ustime, sizeof ustime, timeFormat, gmtime((time_t *)
> &upsince));
> +
> + now_val = now;
> + strftime(udate, sizeof udate, timeFormat, gmtime(&now_val));
> + time_t upsince_val = upsince;
> + strftime(ustime, sizeof ustime, timeFormat, gmtime(&upsince_val));
funky indent... (and in a bunch of other places)
The hardcoding of vt 8 in the init script feels wrong as well, but I
guess that's not a regression. (It's going to clash with a display
manager that starts before it or in parallel.)
Looks reasonable otherwise.
Cheers,
Julien
signature.asc
Description: Digital signature
