On Wed, Jun 27, 2012 at 01:06:44AM +0530, Ritesh Raj Sarraf wrote: > On Tuesday 26 June 2012 09:32 PM, Guido Günther wrote: > > At which place should gbp pick up DEBEMAIL (ond possibly override the > > options from .gitconfig)? I don't think it ever did that (at least not > > on prupose). In git-dch we parse the commit to get the email address of > > the patch author but that's rather the other way around. > > I agree that gbp never promised looking at the ~/.devscripts file. > > But maybe devscripts is the place you should also consider looking at. > Quoting the manpage. > > ================== > Several scripts of the devscripts suite use the following > environment variables. Check the man page of individual > scripts for more details on how the variables are used. > > DEBEMAIL > Email of the person acting on a given Debian package via > devscripts. > > DEBFULLNAME > Full name (first + family) of the person acting on a given > Debian package via devscripts. > ================== > > The default git config is global. I definitely can customize each git > repo with a custom setting. But consider gbp's use case. It is mostly > going to be used for Debian packaging. Hence, instead of referring to > the global git config for a user, you might want to consider looking a > more debian specific home.
So you propose to extract the git author/commiter (e.g. for generated tags) from DEBFULLNAME/DEBEMAIL instead of letting git handle this? We could set GIT_{AUTHOR,COMMITER}_{NAME,EMAIL} to the above variables. But I wonder if it isn't more confusing to deviate from what git does by default. But having this as an options certainly makes sense. Cheers, -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org