Hi Bas, http://mentors.debian.net/package/ptop Uploaded: 2012-06-23 20:07
Some of my comments on RFS 675701 are not yet processed in this package. I also have the following additional comments. The file pg_top.c contains "Copyright (c) 1989 - 1994, William LeFebvre, Northwestern University" but I don't find Northwestern University anywhere in debian/copyright. You write in debian/copyright that pg_top.c has the BSD license. That is not true. Files like aclocal.m4 are usually not mentioned in debian/copyright. It is not wrong to mention them anyway, but if you mention them, then the copyright and license information must be accurate. You write in debian/copyright that aclocal.m4 has the BSD license. That is not true. I don't find "Copyright (c) Richard Henderson <r...@tamu.edu>" in the upstream source code, so why is this in debian/copyright ? You changed the license of the Debian packaging. Did Adam Majer agree with that ? What does "activate in control file" in debian/changelog mean ? I seen no change in debian/control corresponding to that. Why skip version 3.6.2-6 ? Optional: I see that the text of the BSD license is repeated a few times. It is OK to mention that text only once and then point to that text repeatedly like this "License: BSD, see below" or "License: BSD, see above". That would shorten debian/copyright quite a bit. Optional: It is OK to put all files and copyright notices for files with the same license together, like this : "The following files have one or more of the following copyright notices and have the following license : ...". That would also shorten debian/copyright quite a bit. Optional: It is OK to specify most files with simply "Files: *" and to use "Files: filename1, filename2" for exceptions. That would simplify maintenance of the debian/copyright in the future. Regards, Bart Martens -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
