Bug#293668: lessdisks: postinst should not call keycopy or generate gid file

[Vagrant Cascadian]

Package: lessdisks
Version: 0.5.3cvs.20040906-11
Severity: normal
Tags: patch

the postinst script calls lessdisks-keycopy, and also generates the
$lessdisks_path/etc/lessdisks/gid file.

this should really just be part of the lessdisks-install script, because
if they change the value of $lessdisks_path between package installation
and running lessdisks-install, the copied ssh keys and the lessdisks gid
file will still be in the old location.

attached is a patch to remove these from the postinst, and a second
patch to call lessdisks-keycopy from lessdisks-install (it already
handles the gid file creation).

live well,
  vagrant

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i586)
Kernel: Linux 2.6.8-2-386
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages lessdisks depends on:
ii  adduser             3.59                 Add and remove users and groups
ii  binutils            2.15-5               The GNU assembler, linker and bina
ii  coreutils [shelluti 5.2.1-2              The GNU core utilities
ii  debconf             1.4.30.11            Debian configuration management sy
ii  debootstrap         0.2.45-0.1           Bootstrap a basic Debian system
ii  lessdisks-easydialo 0.5.3cvs.20040906-11 flexible diskless (x)terminal syst
ii  nfs-kernel-server [ 1:1.0.6-3.1          Kernel NFS server support
ii  shellutils          5.2.1-2              The GNU shell programming utilitie
ii  wget                1.9.1-8              retrieves files from the web

-- debconf information excluded

diff -ur lessdisks-0.5.3cvs.20040906.orig/debian/lessdisks.postinst 
lessdisks-0.5.3cvs.20040906/debian/lessdisks.postinst
--- lessdisks-0.5.3cvs.20040906.orig/debian/lessdisks.postinst  2005-02-04 
12:13:34.000000000 -0800
+++ lessdisks-0.5.3cvs.20040906/debian/lessdisks.postinst       2005-02-04 
12:36:12.000000000 -0800
@@ -52,13 +52,8 @@
       adduser $user $lessdisks_group
     done
   fi
-  # need to preserve identical group id on the server and 
-  # terminal's root filesystem.
-  mkdir -p $lessdisks_path/etc/lessdisks/
-  grep "^$lessdisks_group:" /etc/group | awk -F : '{print $3}' > 
$lessdisks_path/etc/lessdisks/gid
   chown root.$lessdisks_group /etc/lessdisks-install.conf
   chmod g+rw /etc/lessdisks-install.conf
-  /usr/sbin/lessdisks-keycopy
 fi
 
 #DEBHELPER#

diff -ur lessdisks-0.5.3cvs.20040906.orig/install/usr-sbin/lessdisks-install 
lessdisks-0.5.3cvs.20040906/install/usr-sbin/lessdisks-install
--- lessdisks-0.5.3cvs.20040906.orig/install/usr-sbin/lessdisks-install 
2004-09-05 05:22:13.000000000 -0700
+++ lessdisks-0.5.3cvs.20040906/install/usr-sbin/lessdisks-install      
2005-02-04 12:39:29.000000000 -0800
@@ -591,6 +591,8 @@
   echo
 fi
 
+/usr/sbin/lessdisks-keycopy
+
 echo "lessdisks stage2 install finished. hit enter to continue"
 read pause
 

signature.asc
Description: Digital signature