Source: midgard2-core
Version: 10.05.6-1
Severity: serious
Hi,
thanks for the update to libgda5! This though made me have a look at the
midgard2-core source package, and I noticed several packaging mistakes.
- Build-Depends on gir1.2-gda-5.0. The introspection mini policy [1] says
that the corresponding libgda-5.0-dev will have a dependency on
gir1.2-gda-5.0. So an explicit Build-Depends is not necessary.
- library package name (libmidgard2) doesn't reflect the SONAME
libmidgard2.so.2010
- hard-coded shlibs dependencies:
Depends: libglib2.0-0 (>=2.12), libxml2 (>=2.6.11), libdbus-glib-1-2
Those should be automatically set via shlibs:Depends
- The gir package name (gir1.2-midgard2) doesn't reflect the typelib name
Midgard-10.05.typelib. See [1] for how gir packages should be named.
- hard-coded and missing gir dependencies.
As you are providing a gir package, you should call dh_girepository in
debian/rules [1] and add ${gir:Depends} to your gir package. This means
you don't need to hard-code the Depends on gir1.2-glib-2.0. If you
debian/gir1.2-midgard2.substvars (in your build directory), you will
notice that "gir:Depends=gir1.2-freedesktop, gir1.2-gda-5.0,
gir1.2-glib-2.0, libmidgard2 (>= 10.05)", i.e. you are currently
missing a dependency on gir1.2-gda-5.0 and gir1.2-freedesktop.
- The hard-coded depends on libgirepository1.0-1 looks wrong and should
be removed.
- The gir1.2-midgard2 package ships *both* the .typelib and .gir file.
Again, have a look at [1]. The .gir files belongs into the -dev
package. When you move the file, don't forget the necessary
Breaks/Replaces.
- You are having
Depends: libmidgard2 (>= ${source:Version}), midgard2-common (>=
${source:Version})
between arch:any packages. This looks strange. What's the reason for
this?
- The package uses source format 3.0 (quilt), yet you build-depend on
quilt and include /usr/share/quilt/quilt.make in debian/rules.
With 3.0 (quilt) you can/should drop the quilt build dependency and
the quilt.make include.
Cheers,
Michael
[1] /usr/share/doc/gobject-introspection/policy.txt
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
