Package: amule
Version: 2.3.1-7
Severity: normal
Tags: patch upstream
User: debian-...@lists.debian.org
Usertags: ld-as-needed
amule fails to build when --as-needed linker option is enabled,
because of incorrect order of parameters passed to ld. Here's a log of
failed build in Ubuntu:
https://launchpadlibrarian.net/104846981/buildlog_ubuntu-quantal-i386.amule_2.3.1-7_FAILEDTOBUILD.txt.gz
See also
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries
The attached patch was used in Ubuntu to fix the problem.
https://launchpad.net/ubuntu/+source/amule/2.3.1-7ubuntu1
-- System Information:
Debian Release: wheezy/sid
APT prefers precise-updates
APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500,
'precise-proposed'), (500, 'precise'), (100, 'precise-backports')
Architecture: i386 (i686)
Kernel: Linux 3.2.0-25-generic (SMP w/2 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Description: fix build with --as-needed linker option
Author: Ilya Barygin <randomact...@ubuntu.com>
--- amule-2.3.1.orig/src/utils/plasmamule/Makefile.am
+++ amule-2.3.1/src/utils/plasmamule/Makefile.am
@@ -31,7 +31,7 @@ plasma_engine_plasmamule_so_CXXFLAGS = -
plasma_applet_plasmamule_so_CXXFLAGS = -shared -D__IMG_PATH__=\"${KDE_ICON_PATH}\" -I${KDE_HEADER_DIR} ${QT_GUI_CXXFLAGS} -DPIC -fPIC ${DEBUGFLAG}
plasmamule_engine_feeder_CXXFLAGS = -I${KDE_HEADER_DIR} ${QT_GUI_CXXFLAGS} ${DEBUGFLAG}
-plasmamule_engine_feeder_LDFLAGS = ${QT_GUI_LIBS} -lkdecore -lplasma ${QT_DBUS_LDFLAGS}
+plasmamule_engine_feeder_LDADD = ${QT_GUI_LIBS} -lkdecore -lplasma ${QT_DBUS_LDFLAGS}
noinst_HEADERS = plasma-engine-plasmamule.h plasma-applet-plasmamule.h plasmamule-dbus.h qt-emc.h
--- amule-2.3.1.orig/src/utils/plasmamule/Makefile.in
+++ amule-2.3.1/src/utils/plasmamule/Makefile.in
@@ -402,7 +402,7 @@ nodist_plasma_applet_plasmamule_so_SOURC
plasma_engine_plasmamule_so_CXXFLAGS = -shared -I${KDE_HEADER_DIR} ${QT_CORE_CXXFLAGS} -DPIC -fPIC ${DEBUGFLAG}
plasma_applet_plasmamule_so_CXXFLAGS = -shared -D__IMG_PATH__=\"${KDE_ICON_PATH}\" -I${KDE_HEADER_DIR} ${QT_GUI_CXXFLAGS} -DPIC -fPIC ${DEBUGFLAG}
plasmamule_engine_feeder_CXXFLAGS = -I${KDE_HEADER_DIR} ${QT_GUI_CXXFLAGS} ${DEBUGFLAG}
-plasmamule_engine_feeder_LDFLAGS = ${QT_GUI_LIBS} -lkdecore -lplasma ${QT_DBUS_LDFLAGS}
+plasmamule_engine_feeder_LDADD = ${QT_GUI_LIBS} -lkdecore -lplasma ${QT_DBUS_LDFLAGS}
noinst_HEADERS = plasma-engine-plasmamule.h plasma-applet-plasmamule.h plasmamule-dbus.h qt-emc.h
CLEANFILES = *.moc
MAINTAINERCLEANFILES = Makefile.in
