Hello,

On Sat, 09 Jun 2012 12:55:47 +0200
markus schnalke <mei...@marmaro.de> wrote:

> > IFACE can be used only when you're sure it holds what you expect it
> > to hold. If you expect a name of iface ... inet stanza, you should
> > also check ADDRFAM for "inet". If you probably expect inet6 things
> > too, you should check ADDRFAM for it as well.

> Can we conclude that there is an issue that should be solved, but it
> is not related to masqmail anymore? (Well, at least as soon as the new
> package is uploaded.)

No, it's masqmail's issue. It's not using IFACE properly.

> Am I right that doing another check would be a hack to solve the
> issue?
> 
>       if [ ! x"$IFUP_IFACES" = x"all" ] ; then
>               if [ ! x"$IFACE" = x"--all" ] ; then
>                       echo $IFUP_IFACES | grep $IFACE > /dev/null
> || exit 0 fi
>       fi

No. First of all, drop those x-es. They aren't needed at all. Second,
call grep as `grep -- "$IFACE"` (note quotes and --). Third, first
thing you should check at the very beginning of your script is ADDRFAM
which should be probably either inet or inet6, but I guess in your
script it's optional, so fixing grep invocation should be enough.

-- 
WBR, Andrew

Attachment: signature.asc
Description: PGP signature

Reply via email to