Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.
[...]
> Template: ledgersmb/admin_login
> Type: string
> Default: ledgersmb
> +_Description: Database administrative user login:
> + Please enter the login of the LedgerSMB database administrative user. This
> + login is needed, for instance, by setup.pl in the web interface.
> I'm not entirely convinced that we should mention "setup.pl". Better
> talk about the "Configure database" part of the web interface or
> something like this.
>
> I also tried to avoid the "for for" construction....Justin will
> probably have better suggestions.
In fact I like yours. It's possible we could say:
login is needed, for instance, to use setup.pl in the web interface.
But looking at setup.pl it's not clear that users would know they were
using it. My patch just has:
login is needed for the administrative web user interface.
(Translators probably have a rendering for that by now.)
> Template: ledgersmb/admin_password
Ditto.
> Template: ledgersmb/debconf_install
> Type: boolean
> Default: false
> _Description: Configure LedgerSMB automatically?
> The configuration program for the package can automatically configure
> + some aspects of LedgerSMB, noticeably the LedgerSMB database user.
I'd make that just:
some aspects of LedgerSMB, such as the LedgerSMB database user.
(It's obvious that that's an aspect particularly worthy of mention
because here it is being singled out for a mention.)
> --- ledgersmb.old/debian/control 2012-05-22 08:27:44.223689383 +0200
> +++ ledgersmb/debian/control 2012-05-25 07:04:05.977736852 +0200
> @@ -22,10 +22,10 @@
> Suggests: postgresql, lpr, libnet-tclink-perl, latex-cjk-all
> Conflicts: ledger-smb
> Replaces: ledger-smb
> -Description: Financial accounting and ERP program
> +Description: financial accounting and ERP program
> LedgerSMB is a double-entry financial accounting and Enterprise Resource
> - Planning system which offers Accounts Receivable, Accounts Payable and
> General
> - Ledger tracking as well as inventory control and fixed assets handling. The
> + Planning system which offers "Accounts Receivable", "Accounts Payable" and
> "General
> + Ledger" tracking as well as inventory control and fixed assets handling. The
> LedgerSMB client can be a web browser or a programmed API call. The goal of
> the
> LedgerSMB project is to bring high quality ERP and accounting capabilities
> to
> small and midsize businesses.
>
> Very good package description!
>
> I only found a coupld glitches.
Agreed. I was only thinking about capitalising the phrase "Small and
Midsize Businesses" at the end to strengthen the why-the-name hint
(here in Europe they're Small and Medium Enterprises, and SMB is
mostly the old name for CIFS).
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
diff -ru old/control new/control
--- old/control 2012-05-22 19:51:19.055715052 +0100
+++ new/control 2012-05-25 09:32:47.799393759 +0100
@@ -22,10 +22,10 @@
Suggests: postgresql, lpr, libnet-tclink-perl, latex-cjk-all
Conflicts: ledger-smb
Replaces: ledger-smb
-Description: Financial accounting and ERP program
+Description: financial accounting and ERP program
LedgerSMB is a double-entry financial accounting and Enterprise Resource
- Planning system which offers Accounts Receivable, Accounts Payable and General
- Ledger tracking as well as inventory control and fixed assets handling. The
+ Planning system which offers "Accounts Receivable", "Accounts Payable" and
"General
+ Ledger" tracking as well as inventory control and fixed assets handling. The
LedgerSMB client can be a web browser or a programmed API call. The goal of
the
LedgerSMB project is to bring high quality ERP and accounting capabilities to
- small and midsize businesses.
+ Small and Midsize Businesses.
diff -ru old/templates new/templates
--- old/templates 2012-05-22 19:51:14.095725811 +0100
+++ new/templates 2012-05-25 09:33:54.751392640 +0100
@@ -1,23 +1,23 @@
Template: ledgersmb/admin_login
Type: string
Default: ledgersmb
-_Description: Login for the Database Administrative user:
- Please enter the login of the LedgerSMB Database Administrative user. This
- login is needed for, for instance, running setup.pl in the Web Interface.
- Note that 'ledgersmb' is the standard for this.
+_Description: Database administrative user login:
+ Please enter the login of the LedgerSMB database administrative user. This
+ login is needed for the administrative web user interface.
Template: ledgersmb/admin_password
Type: password
Default: LEDGERSMBINITIAL
-_Description: Password for the Database Administrative user:
- Please enter the password of the LedgerSMB Database Administrative user.
- This password is needed for, for instance, running setup.pl in the Web
- Interface.
+_Description: Database administrative user password:
+ Please enter the password of the LedgerSMB database administrative user.
+ This password is needed for the administrative web user interface.
Template: ledgersmb/debconf_install
Type: boolean
Default: false
_Description: Configure LedgerSMB automatically?
The configuration program for the package can automatically configure
- LedgerSMB, at least and especially for the LedgerSMB Database User.
-
+ some aspects of LedgerSMB, such as the LedgerSMB database user.
+ .
+ More general information about the initial configuration of the application
+ can be found in /usr/share/doc/ledgersmb/README.Debian.
Source: ledgersmb
Section: web
Priority: optional
Maintainer: Debian LedgerSMB Team
<pkg-sql-ledger-discuss...@lists.alioth.debian.org>
Uploaders: Robert James Clay <j...@rocasa.us>
Build-Depends: debhelper (>= 8), po-debconf, libmodule-install-perl
Standards-Version: 3.9.3
Homepage: http://www.ledgersmb.org/
Vcs-Svn: svn://svn.debian.org/pkg-sql-ledger/ledger-smb/trunk
Vcs-Browser: http://svn.debian.org/wsvn/pkg-sql-ledger/ledger-smb/trunk
Package: ledgersmb
Architecture: all
Depends: ${perl:Depends}, ${misc:Depends}, perl (>= 5.8.0-1),
libconfig-std-perl,
libconfig-any-perl, libmime-lite-perl, libdbi-perl, libdbd-pg-perl,
liberror-perl,
liblocale-maketext-lexicon-perl (>= 0.62-1), libtemplate-perl (>=2.14-1),
libhtml-parser-perl, liblog-log4perl-perl, libdatetime-perl, apache2 |
httpd-cgi,
libcgi-simple-perl, libfile-mimeinfo-perl, libio-stringy-perl,
postgresql-client, postgresql-contrib, dbconfig-common
Recommends: default-mta | mail-transport-agent, texlive-latex-recommended,
libopenoffice-oodoc-perl,
libmath-bigint-gmp-perl, libparse-recdescent-perl
Suggests: postgresql, lpr, libnet-tclink-perl, latex-cjk-all
Conflicts: ledger-smb
Replaces: ledger-smb
Description: financial accounting and ERP program
LedgerSMB is a double-entry financial accounting and Enterprise Resource
Planning system which offers "Accounts Receivable", "Accounts Payable" and
"General
Ledger" tracking as well as inventory control and fixed assets handling. The
LedgerSMB client can be a web browser or a programmed API call. The goal of the
LedgerSMB project is to bring high quality ERP and accounting capabilities to
Small and Midsize Businesses.
Template: ledgersmb/admin_login
Type: string
Default: ledgersmb
_Description: Database administrative user login:
Please enter the login of the LedgerSMB database administrative user. This
login is needed for the administrative web user interface.
Template: ledgersmb/admin_password
Type: password
Default: LEDGERSMBINITIAL
_Description: Database administrative user password:
Please enter the password of the LedgerSMB database administrative user.
This password is needed for the administrative web user interface.
Template: ledgersmb/debconf_install
Type: boolean
Default: false
_Description: Configure LedgerSMB automatically?
The configuration program for the package can automatically configure
some aspects of LedgerSMB, such as the LedgerSMB database user.
.
More general information about the initial configuration of the application
can be found in /usr/share/doc/ledgersmb/README.Debian.
