On Sun, May 20, 2012 at 07:21:10PM -0500, Jonathan Nieder wrote: > Hi Simon, > > Simon Ruderich wrote: >> I think just patching in LDFLAGS is simpler than fixing configure >> and adding TEST_LDFLAGS in a few places. > > The problem with this approach is that all the distros are going to > have to make the same change. If the upstream build rules make this > too inconvenient, the natural thing to do is to discuss with > upstream[*] how to make the Makefile better and then make the same > change in the Debian package. The zlib developers are very friendly > and responsive, so it shouldn't be too painful.
Hello Jonathan, I concur completely, sending those changes to upstream is always the best. Normally I recommend it in my patches, but this time I forgot. The reason why I recommended patching the Makefile to use LDFLAGS, is because it's the correct way to handle compiler flags from the environment. I didn't mean to imply that this should be a Debian only change, fixes to the build system should always get sent to upstream by the maintainer. Regards, Simon -- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9
pgpCidMZD11x6.pgp
Description: PGP signature
