Hello, First of all I think that bringing interfaces up without their prior declaration isn't a good idea, but well, okay, let's skip this for a while.
Vlan package is going to be dropped, and in its absence there's nothing to bring those interfaces up unless you try to configure these vlans on your own using ip utility. By the way, how about non-vlan interfaces? How do they get configured without being declared in /e/n/i? Also, this check: [ ! -d /sys/class/net/$port ] && [ -x /etc/network/if-pre-up.d/vlan ] isn't quite correct. If we have additional options for vlan interface set in /e/n/i, they will be silently ignored, which is no good. You should check if it's defined in /e/n/i somehow. For example, you can ifup it first, then check if interface is available, and if not... Or you could use ifquery for that, but in it's current shape it's not that easy as I would like it to be, as it always returns true regardless of interface definition presense (to be fixed tomorrow). Also, mkdir -p /var/run/network seems to be unneeded, I'd rather just check if /run/network exists and quit without doing anything if it doesn't. (Hope I didn't forget anything I wanted to say or anything or what we discussed on IRC.) -- WBR, Andrew
signature.asc
Description: PGP signature
