On Sat, May 12, 2012 at 2:36 AM, Paul Wise <p...@debian.org> wrote: > On Fri, May 11, 2012 at 8:48 AM, Vincent Cheng wrote: > >> I'm looking for a sponsor for my package "logisim". > > I don't intend to sponsor this but here is a review: > > src/com/cburch/logisim/file/ReaderInputStream.java is Apache 2.0 > licensed, not GPL. That isn't compatible with GPLv2 but since the rest > of the code is GPLv2+ that seems to be Ok (GPLv3 is compatible), I > wonder why it is licenced that way though, perhaps you could ask > upstream. > > Please install resources/logisim/img/logisim-icon-*.png to > /usr/share/icons/hicolor/*/apps/logisim.png and put Icon=logisim in > the .desktop file.
Fixed. > doc/search_lookup_*/ look like generated files, is it possible to > build those on Debian? If not they should probably be removed. I'm not sure about that, will have to ask upstream. > A bunch of the icons and images mention they were created in the GIMP, > I wonder if upstream has GIMP XCF files lying around. I also wonder > about the fonts used. > > lintian complaints that are bugs in lintian should not get overridden. > Since a bug is already filed, you should either ignore the warning and > or send a patch to the lintian maintainers. Ok. I've also added a quick patch to that bug report. > There are a number of duplicate and triplicate files. Please see if it > is possible for upstream to de-duplicate them or to use symlinks to > de-duplicate them on Debian. > > Please send upstream a patch for the unwanted BOM. Wow, > get-orig-source is ugly, it would be nice if upstream released sane > source tarballs. Please contact them about that and also point them at > our upstream guide (which has some Java-related links): > > http://wiki.debian.org/UpstreamGuide > > The packaging in general is pretty good, you may find a sponsor with > pkg-electronics or perhaps debian-science: > > http://wiki.debian.org/PkgElectronics > http://wiki.debian.org/Teams/DebianScience > http://wiki.debian.org/DebianScience > http://wiki.debian.org/DebianScience/Electronics Thanks, I'll ask around! > jlint finds a lot of issues, you might like to tell upstream about it. > > lintian: > > P: logisim: no-upstream-changelog > > pngcheck: > > $ pngcheck -q resources/logisim/img/logisim-icon-16.png > resources/logisim/img/logisim-icon-16.png this is neither a PNG or > JNG image nor a MNG stream > ERROR: resources/logisim/img/logisim-icon-16.png > $ file resources/logisim/img/logisim-icon-16.png > resources/logisim/img/logisim-icon-16.png: GIF image data, version 89a, 16 x > 16 > > desktop-file-validate: > > debian/logisim.desktop: error: (will be fatal in the future): value > "logisim-icon-128.png" for key "Icon" in group "Desktop Entry" is an > icon name with an extension, but there should be no extension as > described in the Icon Theme Specification if the value is not an > absolute path Fixed. Thanks for the review! It looks like I have a lot to talk about with upstream... Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
