Bug#672326: arno-iptables-firewall: consider using init script LSB log_xxx_msg functions

[Christian PERRIER]

Quoting Mike Miller (mtmil...@ieee.org):
> Package: arno-iptables-firewall
> Version: 2.0.1.b-2
> Severity: wishlist
> 
> Please consider using the LSB log_success_msg, et al, in the init script
> instead of plain old echo.  Only noticed this recently when the "fancy output"
> feature of lsb-base was uploaded.


I just played a bit and went with the attached quite crude
patch. Untested....



diff -u arno-iptables-firewall-2.0.1.old/etc/init.d/arno-iptables-firewall 
arno-iptables-firewall-2.0.1/etc/init.d/arno-iptables-firewall
--- arno-iptables-firewall-2.0.1.old/etc/init.d/arno-iptables-firewall  
2012-03-25 16:13:18.000028724 +0200
+++ arno-iptables-firewall-2.0.1/etc/init.d/arno-iptables-firewall      
2012-05-10 07:23:34.674352380 +0200
@@ -28,22 +28,24 @@
 
 test -x $PROGRAM || exit 0
 
+. /lib/lsb/init-functions
+
 if [ "$VERBOSE" = "0" ]; then
   case "$1" in
     start)
-      echo "Starting Arno's Iptables Firewall..."
+       log_daemon_msg "Starting Arno's Iptables Firewall"
     ;;
 
     stop)
-      echo "Stopping Arno's Iptables Firewall..."
+       log_daemon_msg "Stopping Arno's Iptables Firewall"
     ;;
 
     restart)
-      echo "Restarting Arno's Iptables Firewall..."
+       log_daemon_msg "Restarting Arno's Iptables Firewall"
     ;;
 
     force-reload)
-      echo "(Forced) reloading Arno's Iptables Firewall..."
+       log_daemon_msg "Forced reloading of Arno's Iptables Firewall"
     ;;
 
     status)

signature.asc
Description: Digital signature