On Wednesday, May 09, 2012 08:00:50 AM Ansgar Burchardt wrote: > forcemerge 661665 671277 > thanks > > Hi Paul, > > please update the old RFS bug if you address issues from a review (and > the package wasn't uploaded). It makes it easier to see the whole > picture in a later review. (Also the older RFS request would still show > on the bug tracker.)
Yes I believe I have addressed most of the issues refeneced in the review.
I believe I have fixed most these issues with the release indicated by bug
671277, which was merged with this one.
Case by case below:
> Lintian emits:
> P: openastro.org source: debian-control-has-unusual-field-spacing line 5
fixed.
> "debhelper (>= 7.0.50~)" instead of "debhelper (>= 7.0.50)" would be a
> bit more friendly to backporters.
> With dh_python2, you should use X-Python-Version, not XS-Python-Version.
> Also, remove XB-Python-Version.
>
> The package is arch:all, so there's no point including ${shlibs:Depends}
> in Depends, as it won't be ever substituted.
fixed.
> Is there a reason for patching _comments_ in
> 0005-rename-openastro.py-as-required-by.patch? That looks strange.
Soebody might read the comments and be confused.
> When built with restrictive umask (e.g. 027), the package FTBFS:
> | dh_fixperms
I believe I have fixed this issue.
> Then, if I try to build it again it fails with:
> | dpkg-source -b openastro.org-1.1.25
It now builds twice.
> Are the Python modules included in this package supposed to be used by
> other software? If yes, then the package name should be
> python-openastromod. If no, then please move them to a private
> directory.
I have filed a bug against upstream for poor documentation of this module.
Because I believe it is too badly documented to be made public. I have moved
it to a private location for now, and modified openastro script, to find it at
this new location.
> Version number passed to distutils.core.setup() contains a trailing
> newline. Please report his to upstream.
I do not completely understand this. If this problem presists, I will file a
bug against the upstream. Please tell me if this problem still exists!
>
> As the BTS will only show the older report after merging:
>
> The updated package can be found at
>
> dget -x
> http://mentors.debian.net/debian/pool/main/o/openastro.org/openastro.org_1.
> 1.25+dfsg-4.dsc
>
> Regards,
> Ansgar
--
Paul Elliott 1(512)837-1096
pelli...@blackpatchpanel.com PMB 181, 11900 Metric Blvd Suite J
http://www.free.blackpatchpanel.com/pme/ Austin TX 78758-3117
signature.asc
Description: This is a digitally signed message part.
