Package: rdist
Version: 6.1.5-16+b1
Severity: normal

Dear Maintainer,

rdist of lenny invokes /usr/bin/oldrdist (from obsoleted 44bsd-rdist
package) for -Server, but rdist of squeeze invokes /usr/ucb/oldrdist.


Detail description:

rdist 6.1.5-13 (lenny version) invokes /usr/bin/oldrdist for -Server
(from 6.1.5-3, according to debian/changelog).

This was set by debian/rules:
>build: patch build-stamp
>build-stamp:
>        dh_testdir
>
>        DEFS_LOCAL=-D_PATH_OLDRDIST=\\\"/usr/bin/oldrdist\\\" $(MAKE)
>
>        touch build-stamp

But rdist 6.1.5-16 (squeeze version) invokes /usr/ucb/oldrdist,
since env $DEFS_LOCAL is hidden by Makefile.local.

This problem was introduced by debian/patches/13-fedora-lfs.patch.
>--- a/Makefile.local    2009-07-03 13:08:33.000000000 +1000
>+++ b/Makefile.local    2009-07-03 13:20:40.000000000 +1000
>@@ -20,7 +20,7 @@
> # Add any local definitions you want pass to the compiler to DEFS_LOCAL
> # below.  This includes those items found in "config/config.h".
> #
>-#DEFS_LOCAL    = -DDIRECT_RCMD
>+DEFS_LOCAL     = -O2 -g -pipe -Wall -D_POSIX_SOURCE -D_GNU_SOURCE 
>-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
>
> #
> # Add any local libraries that your system might need to LIBS_LOCAL below.


Suggested fix:

I attached modified version of 13-fedora-lfs.patch.

This changes 13-fedora-lfs.patch to move these options from DEFS_LOCAL (in
Makefile.local) to CFLAGS_OS (in config/mf.linux), because I think these
options are system-specific and DEFS shouldn't include non-defs option
like "-O2 -g -pipe -Wall". And I confirmed kFreeBSD and Hurd is treated as
"linux" in build/os-type (by #415149), so these ports may use
config/mf.linux too.



Regards,
Nobuhiro

Attachment: 13-fedora-lfs.patch
Description: Binary data

Reply via email to