[Peter S Galbraith]

> Hello,
> A while ago, someone suggested that your auto-header.el be added to
> Debian in the package emacs-goodies-el.  The request and this email
> is archived here:

>  http://bugs.debian.org/314664

> I just looked at the file and have a few suggestions, if you don't mind:

> 1- run `M-x checkdoc' on it and you'll find a few minor things to fix
>    like the first line of doc strings that should be complete
>    sentences.  Many functions don't have doc strings at all.

Ran checkdoc and fixed all the suggestions there.  Been a while since
I wrote this thing.  At that time you were told not to include doc
strings unless necessary.  Seems things have changed since then.

> 2- Shouldn't this be a minor-mode ?  That would avoid the global keymap
>    bindings and would reduce the autoload cookies to only the minor-mode
>    command.

Yeah.  I don't know.  I guess it depends on the usage scenario.  Do
you suggest that you first enable the minor mode before invoking the
command to insert file or function headers?  And how about automatic
updates when saving the buffer?  How does that play along with minor
modes?  I honestly don't know/can't remember.

> Looking forward to hearing your comments!

It's been years since I did any emacs lisp stuff, so I'm kind of not
entirely up to date regarding what conventions to use.

        eSk


Attachment: auto-header.el
Description: Binary data

Reply via email to