Source: xbmc-live Version: 2:11.0~git20120423.cd20772-2 Severity: important
The xbmc-live package needs to be reworked (IMO). Here are some things about this package that stand out to me. postinst maintainer script. * The script reads /etc/default/xbmc-live but no such file is installed. Whatever resides in /etc/default/ is meant for the sysv init scripts anyway so the line reading /etc/default/xbmc-live should be dropped. * Line changing allowed_users in Xwrapper.config. Is this line really necessary? I don't believe it's a good idea to allow all users to start X. Besides, it's poor practice for a package to override local administrator settings such as any settings in /etc. * Choosing an account to use with xbmc-live. I believe it would be better to simply choose an account to be used with xbmc-live (i.e. just choose 'xbmc'). This would help in installation of configuration files as then we could ship any needed config files in the xbmc-live package and not have to generate them with the maintainer scripts. Shipping the config files this way also ensures that any modifications done by the local administrator are not overridden after each update of xbmc-live. Choosing a dedicated account for xbmc will also remove the need to override the group settings for any preexisting user account. * Allow users to override password for dedicated xbmc-live account. It would be a good idea if users can override the default password used for the dedicated account. debconf can be used in this case. * sudoers config file. Maybe something else can be done that allows the xbmc-live account to shutdown, reboot, mount, and unmount drives in the system. Also, /etc/sudoers.d should be utilized for the xbmc specific sudo configuration. * grub modifications Modifications to grub need to be supplied in /etc/grub.d. It's generally not a good idea to override settings set by the local administrator. * Seperate xbmc-live package for different init systems. The xbmc-live package supplies scripts for both sysv init and upstart. The sysv and upstart packages are not coinstallable so the xbmc-live package should be split up. -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-2-amd64 (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org