Hi Wookey! Thanks for the patch.
On Fri, Apr 27, 2012 at 06:54:52PM +0100, Wookey wrote: > iproute does not cross-build. It hardcodes 'gcc' rather than using the > correct cross-compiler. This simple patch fixes that. I have just one question about the patch. Doesn't it kind of paper over that the configure script isn't very suitable for cross compiling at all? If I understand it correctly, what you'll be doing after the patch is to, for example, let the configure script check if libatm is available on the build host and then cross-build a binary which tries to link against (a target) libatm? > > Aside: It also specifies $HOSTCC in the top-level makefile and uses it > in netem/Makefile. So far as I can see this achieves nothing and it > should just use $CC everywhere, but I haven't corrected that in case > there is some mysterious upstream reason. > > The 'don't override $CC' part of this patch (i.e the non > debian-specific part) should go upstream. Did you forward it upstream already or do you want me to do it? Maybe you're already aware of this, but anyway... What you need is to (ofcourse) split out the upstream part, format the description part so according to git conventions and add a "Signed-off-by" line stating that you certificate the origin of the contents according to the "Linux Developer Certificate of Origin". Then finally just send it over to Stephen Hemminger <shemminger at vyatta.com> and CC netdev at vger.kernel.org while you're at it might be a good idea. [...] > +override_dh_auto_configure: > + $(CROSS) dh_auto_configure [...] Btw, aren't there any nicer way to solve cross build support in dh then to override like this and add $(CROSS) everywhere? Can't that just be made part of dh? -- Andreas Henriksson -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
