Package: lockdev
Severity: important

The special-casing of ttys looks particularly borked:

  if ( strcmp( p, "tty") == 0 )
        p = ttyname( 0); /* this terminal, if it exists */

What has the ttyname of the controlling terminal got to do with
locking any other device /dev/tty*?  The call could also potentially
return NULL if called by a daemon with no controlling terminal, which
will cause problems later on.

Example: program running on /dev/tty2, calls dev_lock("/dev/ttyS4")
  ==> creates LCK..tty2

Example: daemon without controlling tty calls the same
  ==> ???

My ppc system doesn't have serial ports, so I can't actually test this
properly.  The code doesn't look right, however.


Regards,
Roger


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: powerpc (ppc)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13.1
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to