Package: mozilla-devscripts
Version: 0.30
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hello,
While investigating #667444, I found this inappropriate behavious from
dh_xul-ext: when an addon indicates it is compatible with e.g.
Firefox/max-version 10.*, it generates a Breaks field with Iceweasel (>= 10).
This is wrong, because such an add-on is, by definition, compatible with
Firefox up to and including versions 10.*.
Here is a git-formatted patch to fix that, by replacing >= by >>. You can apply
it by running:
% git am 0001-dh_xul-ext-correct-Breaks-max-version-not.patch
Please note that I did not modify the debian/changelog, I left that to you.
Regards,
- --
Tanguy Ortolo
- -- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1,
'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages mozilla-devscripts depends on:
ii dpkg-dev 1.16.1.2
ii fakeroot 1.18.2-1
ii perl 5.14.2-9
ii python 2.7.2-10
ii python-librdf 1.0.14.1-1
ii python2.6 2.6.7-4
ii python2.7 2.7.3~rc2-1
ii quilt 0.60-2
ii unzip 6.0-5
ii wget 1.13.4-2
ii zip 3.0-4
mozilla-devscripts recommends no packages.
Versions of packages mozilla-devscripts suggests:
pn cvs <none>
pn git 1:1.7.9.1-1
pn mercurial <none>
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCgAGBQJPire8AAoJEOryzVHFAGgZZD4QAIEDfGI0qzcCkHItU1ZWUMEt
ZZJbZmxuALdnJl8UpI//tCIioRg30BGrsNpKRT1zxPfiyXvA04Q3TteeXn038pYw
6/QKvhXQOAmfjfpn8Jj9BMKD4AnAFUbkYflCgNrKVqmtC6nIQQrx3nC/zbYn2G8x
6Cev3LpJ2akYksbIRMIWmnnJ8FCnTzKHAZM6f0Z/IuqqfoTdTmZv5YIxt5WoquMW
DO8BELsesoKDbDXj0K/piV9nrbJS9rj1zkiKazkfa7aBEs3qV8niOvtMEd67daoi
GrsAAEJ5xcIURk/2Mef/v+BGt5WcKkid7ZuijFnF9jrFHmj4FC5gR9Om2tJErB4o
W6rt8ze8MfvtrthD3weOLfKgIkiQkfVcliBqb+0DXqRql3vxgNQNCvuWd5/HyOOV
cL1NmBmq3y3AbZrIcOJ90+PJ2h+TeD2OfnyuowJmDm2lcdXWoogad4JsCjIf1I7J
02ouBZ8Ancs2kc6E6bxeqhomYfhwCREnkYgUfVckBjlodythaeazk6UI2/gGyQLz
/BsLQdU8ndERJoepujwROh4Tf9TgQIg87p7jN0AsO3xwooBdt4BHEQbKIcJ/zy61
AnHvUXXeTArN7om4SpecdtVrZC7U2XlEbHwFt2XZLIyJCJLpXleStF8hmJ/bv4C+
D+CklTIrRMJFkTykSARm
=xKrC
-----END PGP SIGNATURE-----
>From 3be2a1a3b1617fe45190cc2d9fb06d001710bb40 Mon Sep 17 00:00:00 2001
From: Tanguy Ortolo <tan...@ortolo.eu>
Date: Sun, 15 Apr 2012 13:46:49 +0200
Subject: [PATCH] dh_xul-ext: correct Breaks max-version (>> not >=)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------1.7.9.1"
This is a multi-part message in MIME format.
--------------1.7.9.1
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit
An addon is by definition [1] compatible to a target application up to
and *including* its indicated max-version. Thus, it “breaks” this
application's versions *strictly* superior to this max-version.
[1] https://developer.mozilla.org/en/Install_Manifests#targetApplication
The code used to generate a Break field >= max-version; this corrects it
to >> max-version.
---
dh_xul-ext | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--------------1.7.9.1
Content-Type: text/x-patch; name="0001-dh_xul-ext-correct-Breaks-max-version-not.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-dh_xul-ext-correct-Breaks-max-version-not.patch"
diff --git a/dh_xul-ext b/dh_xul-ext
index e003173..6876988 100755
--- a/dh_xul-ext
+++ b/dh_xul-ext
@@ -52,7 +52,7 @@ class XulApp(object):
breaks.append(self.package + " (<< " + deb_min_version + ")")
if self.max_version:
deb_max_version = moz_to_next_debian_version(self.max_version)
- breaks.append(self.package + " (>= " + deb_max_version + ")")
+ breaks.append(self.package + " (>> " + deb_max_version + ")")
return ", ".join(breaks)
def get_eol(self):
--------------1.7.9.1--
