Package: lockdev
Severity: important

In src/lockdev.c, these headers are included:

#if defined (__linux__)
#include <linux/kdev_t.h>
#include <linux/major.h>

Yikes!  This is mixing up the kernel kdev_t with the userspace dev_t
which is possibly different (even more so nowadays, compared with the
age this code was written).

The header <sys/sysmacros.h> includes the macros major() and minor()
as aliases for gnu_dev_major() and gnu_dev_minor() which should be
portable to any glibc system.  Please could you switch to the proper
userspace API for dev_t -> major/minor splitting, and drop the kernel
headers?


Thanks,
Roger


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: powerpc (ppc)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13.1
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to