On Fri, Apr 06, 2012 at 05:34:09PM -0300, rhatto wrote: > Em Fri, Apr 06, 2012 at 09:37:37AM +0200, intrigeri escreveu: > > Please fix ASAP so we can release 1.0 :) > > This is top priority for me. :) > > I opened https://labs.riseup.net/code/issues/3868 to deal with this > new issue. > > Paul, the attached patch possibly fix this issue, but you might need > to manually edit your backup metadata and add a newline between the > human-readable date and the timestamp, so it looks like > > Mon 27 Feb 2012 01:06:08 CET > 1330301168 > > Could you confirm if backups work again after applying this patch? > Thanks again for testing the handler.
I can confirm that after applying the patch, backups seem to be running again (first run with patch was Apr 7 00:36): # ls -l total 40 drwxr-xr-x 19 root root 4096 Apr 9 01:12 daily.1/ drwxr-xr-x 19 root root 4096 Apr 8 01:10 daily.2/ drwxr-xr-x 19 root root 4096 Apr 7 01:14 daily.3/ drwxr-xr-x 19 root root 4096 Apr 7 00:36 daily.4/ drwxr-xr-x 19 root root 4096 Feb 27 01:11 daily.5/ drwx------ 11 root root 4096 Apr 9 01:12 metadata/ What it IMO doesn't solve, is the fact that the handler gave a syntax error and probably returned and error code, but backupninja intepreted this as "backup succesful". This worries me a bit. > [...] > Date: Fri, 30 Mar 2012 11:10:39 +0200 > From: Paul van Tilburg <pau...@debian.org> > > > > Info: Rotating /media/Backup/target.rsync///... > > Debug: daily.25 --> daily.26 > > Debug: daily.24 --> daily.25 > > Debug: daily.23 --> daily.24 > > Debug: daily.22 --> daily.23 > > Debug: daily.21 --> daily.22 > > Debug: daily.20 --> daily.21 > > /usr/share/backupninja/rsync: line 425: [: too many arguments > > /usr/share/backupninja/rsync: line 439: Mon 27 Feb 2012 01:06:08 CET > > 1330301168: > > syntax error in expression (error token is "27 Feb 2012 01:06:08 CET > > 1330301168") > > Info: <<<< finished action /etc/backup.d/10.target.rsync: SUCCESS > > Debug: send report to root > > Info: FINISHED: 1 actions run. 0 fatal. 0 error. 0 warning. Cheers, Paul -- Using the Power of Debian GNU/Linux | E-mail: pau...@debian.org Jabber/GTalk: p...@luon.net | GnuPG key ID: 0x50064181
signature.asc
Description: Digital signature
