Package: libmatchbox
Version: 1.9-osso8-1
Severity: normal
Tags: patch

Dear Maintainer,

The CPPFLAGS hardening flags are missing because configure.ac
clears them. For more hardening information please have a look at
[1], [2] and [3].

The attached patch fixes the issue, if possible it should be sent
to upstream.

To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package and check
the build log (hardening-check doesn't catch everything):

    $ hardening-check /usr/lib/x86_64-linux-gnu/libmb.so.1.0.9
    /usr/lib/x86_64-linux-gnu/libmb.so.1.0.9:
     Position Independent Executable: no, regular shared library (ignored)
     Stack protected: yes
     Fortify Source functions: yes (some protected functions found)
     Read-only relocations: yes
     Immediate binding: no not found!

(Position Independent Executable and Immediate binding is not
enabled by default.)

Use find -type f \( -executable -o -name \*.so\* \) -exec
hardening-check {} + on the build result to check all files.

Regards,
Simon

[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
Description: Restore CPPFLAGS in configure.ac.
 Necessary for (hardening) flags from environment.
Author: Simon Ruderich <si...@ruderich.org>
Last-Update: 2012-04-09

--- libmatchbox-1.9-osso8.orig/configure.ac
+++ libmatchbox-1.9-osso8/configure.ac
@@ -241,8 +241,8 @@ if test x$enable_xsettings != xno; then
       AC_MSG_ERROR([cannot find Xsettings-client headers])
    fi
    	
-   CPPFLAGS="$saved_CPPFLAGS"
-   LIBS="$saved_LIBS"
+   CPPFLAGS="$xsetsaved_CPPFLAGS"
+   LIBS="$xsetsaved_LIBS"
 
    MB_EXTRA_LIBS="$MB_EXTRA_LIBS $XSET_LIBS"	
    MB_EXTRA_CFLAGS="$MB_EXTRA_CFLAGS $XSET_CFLAGS"	

Attachment: signature.asc
Description: Digital signature

Reply via email to