> > While I understand that dpatch allows for functionality far beyond that > > of standard patches, both dpatch-edit-patch and dpatch-convert-diffgz > > work exclusively with standard patches. > > Ermm... you do know that .dpatch is a shell script, right ?
Ermm... you do know that .patch is a simple patch, right ? The easiest solution would be to use the filename extension to distinguish between simple patches and patching scripts. > It's not feasible since it will require a transition. Not really. As outlined above you can handle different extensions in different ways. As for a "transition", as outlined in bug #328730, dpatch-convert-diffgz and dpatch-edit-patch already have an inconsistent syntax. All you need to do is 1) make dpatch-convert-diffgz consistent with dpatch-edit-patch, 2) continue to assume .dpatch when no extension is specified, and 3) when the extension is .patch, treat it as a simple patch. Note that this is also related to bug #328400. In 00list you can assume the .dpatch extension if none is specified, but still allow and properly support the .patch extension. (For that matter you could first search for .dpatch, and then for .patch, but that is irrelevant to the current discussion.) I ask you to reconsider this bug, and primarily for the following reason: You have some very cool functionality in dpatch and the accompanying utiliies that are potentially useful in scope even outside of dpatch (currently I have cdbs in mind, but certainly there are/will be other cases). It strikes me that this is a nonintrusive chance for you to make dpatch into something which is even useful outside of the realm of dpatch; in other words, to expand its utility. Should you fail to do so, the same functionality which you have already implemented will inevitably be reimplemented or copied elsewhere. While your license certainly allows this to happen, focusing common developments in a single central location where possible can be more efficient and mutually beneficial. anyway, Charles -- Thrifty jars for Stay at homes Handy tubes For him Who roams Burma-Shave http://burma-shave.org/jingles/1963/thrifty_jars_for
signature.asc
Description: Digital signature
