tags 293378 +pending
tags 293378 +upstream
tags 293378 +patch
forwarded [EMAIL PROTECTED]
thanks
This one time, at band camp, john said:
> The command
>   hdparm -W 0 /dev/hda
> does not disable write caching on my hard disk. There is no error
> message, but a subsequent
>   hdparm -I /dev/hda
> reports that write caching is still enabled.
> 
> This was working correctly in version 4.5-1.2 (stable) and is
> failing in version 5.8-1 (testing).
> 
> This bug is serious because journalled file systems such as ext3 can
> only guarantee no data loss/corruption if the hardware write caching is
> turned off. So I have marked this bug as "critical".

Bug found, it looks like.  Can you test this patch and see if it works
for as well as it does for me?

---------------------------snip-----------------------------------

--- hdparm.c.old   2005-02-03 22:05:19.000000000 -0500
+++ hdparm.c       2005-02-03 22:05:39.000000000 -0500
@@ -912,6 +912,7 @@
                }
 #ifdef HDIO_SET_WCACHE
                if (!ioctl(fd, HDIO_SET_WCACHE, wcache))
+                       perror(" HDIO_SET_WCACHE failed");
 #endif
                if (ioctl(fd, HDIO_DRIVE_CMD, &args))
                        perror(" HDIO_DRIVE_CMD(setcache) failed");

---------------------------snip-----------------------------------

If so, I'll  push it upstream and release a fixed version shortly.

Thanks for reporting,
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        [EMAIL PROTECTED] |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------

Attachment: pgpHV5PaSY6qG.pgp
Description: PGP signature

Reply via email to