Package: ratmenu Severity: normal Tags: patch Running lintian over the latest ratmenu version (2.2-2) gives this output:
W: ratmenu source: native-package-with-dash-version W: ratmenu: extra-license-file usr/share/doc/ratmenu/LICENSE W: ratmenu: description-synopsis-might-not-be-phrased-properly E: ratmenu: changelog-file-not-compressed ChangeLog W: ratmenu: wrong-name-for-upstream-changelog usr/share/doc/ratmenu/ChangeLog Some analysis of these bugs: ---------------------------- * native-package-with-dash-version The problem is evident: there's no orig.tar.gz, but the package version states that it's upstream 2.2, and Debian revision 2. Since I could find no upstream for this package, it does seem that it actually is a native package. Therefore, the solution would be to drop the Debian revision. This is not enforced by policy, but it's recommended and it's also the standard way of doing it. Please refer to: http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version for more information about this. * extra-license-file usr/share/doc/ratmenu/LICENSE The LICENCE file provided by upstream includes the same information as the debian/copyright file. The solution to this is easy: remove LICENCE from debian/docs * description-synopsis-might-not-be-phrased-properly This warning is triggered by the fact that the synopsis ends with a full stop, and it also starts with a capital letter. The fix for this one is also easy: drop the full stop. * changelog-file-not-compressed ChangeLog Changelog file has to be compressed and this is easily done by using the dh_installchangelogs command. This is a policy violation. Please refer to: http://www.debian.org/doc/debian-policy/ch-docs.html#s-changelogs * wrong-name-for-upstream-changelog Even if this is a native package, it has two changelogs, one for the source code and one for the debian packaging. These files should be stored as: usr/share/doc/ratmenu/changelog.gz usr/share/doc/ratmenu/changelog.Debian.gz Also, the copyright file states: --- Source to ratmenu can be found at: http://reactor-core.org --- However, this site does not seem to be online anymore, this should be changed to reflect the present situation. I'm submitting a patch that fixes all the Lintian problems, except for the native package one. Also, updating the program to the latest debhelper's versions. I hope you apply it. -- Besos, ,''`. Marga : :' : `. `' `-
diff -Nru /tmp/EGtVbLHnMH/ratmenu-2.2/debian/changelog
/tmp/72HhOZt6ZM/ratmenu-2.2/debian/changelog
--- /tmp/EGtVbLHnMH/ratmenu-2.2/debian/changelog 2005-01-31
04:09:27.000000000 -0300
+++ /tmp/72HhOZt6ZM/ratmenu-2.2/debian/changelog 2005-02-02
00:20:07.000000000 -0300
@@ -1,3 +1,16 @@
+ratmenu (2.2-2.1) unstable; urgency=low
+
+ * This is not really an NMU, but was made just to submit a patch.
+ * Remove LICENCE from debian/docs to prevent it from being copied.
+ * Remove final dot from the short description in debian/control
+ * Install changelogs through dh_installchangelogs
+ * Use dh_installman instead of dh_installmanpages, which is deprecated.
+ Add debian/manpages, for it to work.
+ * Add debian/compat file, to use Debhelper 4 features.
+ * Fix debian/rules so that dh_installdeb is run after all the other installs
+
+ -- Margarita Manterola <[EMAIL PROTECTED]> Tue, 1 Feb 2005 23:48:59 -0300
+
ratmenu (2.2-2) unstable; urgency=low
* Fixed prerun and postrun syntax in menu method. Thank you Bill.
diff -Nru /tmp/EGtVbLHnMH/ratmenu-2.2/debian/compat
/tmp/72HhOZt6ZM/ratmenu-2.2/debian/compat
--- /tmp/EGtVbLHnMH/ratmenu-2.2/debian/compat 1969-12-31 21:00:00.000000000
-0300
+++ /tmp/72HhOZt6ZM/ratmenu-2.2/debian/compat 2005-02-01 23:58:29.000000000
-0300
@@ -0,0 +1 @@
+4
diff -Nru /tmp/EGtVbLHnMH/ratmenu-2.2/debian/conffiles
/tmp/72HhOZt6ZM/ratmenu-2.2/debian/conffiles
--- /tmp/EGtVbLHnMH/ratmenu-2.2/debian/conffiles 2005-01-31
03:46:42.000000000 -0300
+++ /tmp/72HhOZt6ZM/ratmenu-2.2/debian/conffiles 1969-12-31
21:00:00.000000000 -0300
@@ -1 +0,0 @@
-/etc/menu-methods/ratmenu
diff -Nru /tmp/EGtVbLHnMH/ratmenu-2.2/debian/control
/tmp/72HhOZt6ZM/ratmenu-2.2/debian/control
--- /tmp/EGtVbLHnMH/ratmenu-2.2/debian/control 2005-01-31 04:08:33.000000000
-0300
+++ /tmp/72HhOZt6ZM/ratmenu-2.2/debian/control 2005-02-02 00:07:59.000000000
-0300
@@ -2,14 +2,14 @@
Section: x11
Priority: optional
Maintainer: Jonathan Walther <[EMAIL PROTECTED]>
-Build-Depends: xlibs-dev, debhelper
+Build-Depends: xlibs-dev, debhelper (>= 4.0.0)
Standards-Version: 3.6.1.1
Package: ratmenu
Suggests: ratpoison, xbindkeys
Architecture: any
Depends: ${shlibs:Depends}
-Description: Creates X menus from the shell.
+Description: Creates X menus from the shell
This is ratmenu, a simple program that allows you to create X menus from the
shell. Although designed for ratpoison, it will work with any ICCCM compliant
window manager.
diff -Nru /tmp/EGtVbLHnMH/ratmenu-2.2/debian/docs
/tmp/72HhOZt6ZM/ratmenu-2.2/debian/docs
--- /tmp/EGtVbLHnMH/ratmenu-2.2/debian/docs 2003-06-09 03:36:18.000000000
-0300
+++ /tmp/72HhOZt6ZM/ratmenu-2.2/debian/docs 2005-02-01 23:42:02.000000000
-0300
@@ -1,3 +1 @@
-ChangeLog
-LICENSE
README
diff -Nru /tmp/EGtVbLHnMH/ratmenu-2.2/debian/manpages
/tmp/72HhOZt6ZM/ratmenu-2.2/debian/manpages
--- /tmp/EGtVbLHnMH/ratmenu-2.2/debian/manpages 1969-12-31 21:00:00.000000000
-0300
+++ /tmp/72HhOZt6ZM/ratmenu-2.2/debian/manpages 2005-02-01 23:54:32.000000000
-0300
@@ -0,0 +1 @@
+ratmenu.1
diff -Nru /tmp/EGtVbLHnMH/ratmenu-2.2/debian/postinst.debhelper
/tmp/72HhOZt6ZM/ratmenu-2.2/debian/postinst.debhelper
--- /tmp/EGtVbLHnMH/ratmenu-2.2/debian/postinst.debhelper 2003-06-19
05:57:37.000000000 -0300
+++ /tmp/72HhOZt6ZM/ratmenu-2.2/debian/postinst.debhelper 1969-12-31
21:00:00.000000000 -0300
@@ -1,77 +0,0 @@
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ -x /usr/bin/update-menus ] && [ -f $inst ] ; then
- chmod a+x $inst
- update-menus
-fi
-# End automatically added section
diff -Nru /tmp/EGtVbLHnMH/ratmenu-2.2/debian/postrm.debhelper
/tmp/72HhOZt6ZM/ratmenu-2.2/debian/postrm.debhelper
--- /tmp/EGtVbLHnMH/ratmenu-2.2/debian/postrm.debhelper 2003-06-19
05:57:37.000000000 -0300
+++ /tmp/72HhOZt6ZM/ratmenu-2.2/debian/postrm.debhelper 1969-12-31
21:00:00.000000000 -0300
@@ -1,55 +0,0 @@
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
-# Automatically added by dh_installmenu
-inst=/etc/menu-methods/ratmenu
-if [ "$1" = "remove" ] && [ -f "$inst" ]; then chmod a-x $inst ; fi
-if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
-# End automatically added section
diff -Nru /tmp/EGtVbLHnMH/ratmenu-2.2/debian/rules
/tmp/72HhOZt6ZM/ratmenu-2.2/debian/rules
--- /tmp/EGtVbLHnMH/ratmenu-2.2/debian/rules 2003-06-09 03:29:47.000000000
-0300
+++ /tmp/72HhOZt6ZM/ratmenu-2.2/debian/rules 2005-02-02 00:26:24.000000000
-0300
@@ -13,19 +13,10 @@
SHELL = /bin/sh
srcdir = .
-INSTALL = /usr/bin/install
-INSTALL_PROGRAM = $(INSTALL) -m 755 -o root -g root
-
ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
INSTALL_PROGRAM += -s
endif
-INSTALL_DATA = $(INSTALL) -m 644 -o root -g root
-INSTALL_DIR = $(INSTALL) -d -m 755 -o root -g root
-INSTALL_SCRIPT = $(INSTALL) -m 755 -o root -g root
-
-DOCDIR = debian/tmp/usr/share/doc/ratmenu
-
build:
dh_testdir
make CC="$(CC)" CFLAGS="$(CFLAGS)"
@@ -45,12 +36,12 @@
dh_testdir
dh_testroot
make -f debian/rules build
- dh_installdeb
- dh_install
dh_installdocs
- dh_installmanpages
+ dh_installman
dh_installmenu
- $(INSTALL_DATA) debian/changelog $(DOCDIR)/changelog.Debian
+ dh_installchangelogs ChangeLog
+ dh_install
+ dh_installdeb
dh_compress
dh_strip
dh_fixperms
signature.asc
Description: Digital signature
