This one time, at band camp, Jari Aalto said: > I would rather see that things are transparent. The reason I wrote a > bug report was that the value 0 was puzzling. I'm sure someone else > could wonder that too. > > 1) The manual page sugges 1M (on absense) ... but config file contains 0? > 2) There are no comments in config file to explain why it needs default > value 0 (compared to the default value in manual), especially when > the value is not deconf-enabled/handled.
It is in the man page:
LogFileMaxSize SIZE
Limit the size of a log file. The logger will be automatically disabled
if the file is greater than SIZE. Value of 0 disables the limit.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Default: 1M
How is that unclear?
I think we are speaking at cross purposes here, perhaps due to some
confusion about what this directive does. Let me try to explain.
LogFileMaxSize does not do anything, in and of itself, about the log
files already present on disk. It does not rotate them, compress them,
or delete old ones. The only thing it does is suppress log output by
clam programs when the log file has reached a size greater than either
the default or the specified config file entry. This results in logging
being turned off at a certain point, but it allows for a certain
paranoia about maximum log file size on severely disk limited systems.
This functionality is not at all useful on most systems that clam will
be installed on. Most systems have more than the few megabytes needed
under /var/log to store the clam logs, and they are by default rotated
by logrotate, compressed, and eventually deleted after a few months.
This is why, in the default setting, log truncation is disabled. And it
is done in exactly the manner explained in the man page.
> I'm not familiar with debconf, but there already are command in the
> default clamd.conf, so I don't see an objection why couldn't there be
> one line more? Is the problem preserving user changes, then the lines
> could be tagged if the scripts need to parse the file.
>
> # debconf-comment 1: ....
> # debconf-comment 2: ....
I can understand the wish for a heavily commented config file. If you
want one, please go ahead and comment the config file with an
explanation of what every switch does. It seems like much more of a
maintenance headache to me than it is worth, however. I would have to
special case comments with tests on the setting of each switch, so that
a non zero argument would look like:
# Stop all logging if log file is larger than 1M
LogFileMaxSize 1M
But an argument of zero would look like:
# Don't abort logging, logrotate will take care of rotating old logs out
# of the way.
LogFileMaxSize 0
And then I get to do the same for all other directives in the config
file. It does not seem worth the maintenace overhead to me. If you
disagree, send me patches against the postinst script, and I will
consider it.
> Anyway, IMO it would be more transparent to the end user if he could
> see "ah, that's why 0 is in there."
But they already can. All they have to do is look at what's in the
config file, and then look it up in the man page, where it is explained.
Take care,
--
-----------------------------------------------------------------
| ,''`. Stephen Gran |
| : :' : [EMAIL PROTECTED] |
| `. `' Debian user, admin, and developer |
| `- http://www.debian.org |
-----------------------------------------------------------------
pgpQDTJf7Zc4U.pgp
Description: PGP signature
