Package: tspc Version: 2.1.1-3 Severity: wishlist Hi.
(1) There must be no executables in /etc/tspc, according to the FHS. Configuration done by shell scripts should be split in the config part that would stay in /etc, and the executable part, which can be put e.g. in /var/lib/<packagename>/. The executable part can source the config part then, so that the config part would be just a sh script fragment. If it was just a matter of choosing one out of a few possible shell scripts, a symlink does this job well (e.g. /etc/X11/X). (2) Also, including the language name in the filename is not a good practice -- should the programming language change, all the references would have to be changed, for example. (3) Oh, and it should be /etc/<packagename>, not /etc/<packagename_with_the_last_character_trimmed> (4) The symlinks really shouldn't be there (but I can't tell whether it's a justifiable workaround without further investigation) Just for a reference: $ ls -l /etc/tsp # [3] total 20 -rwxr-xr-x 1 root root 1671 Jan 4 20:59 checktunnel.sh [1,2] -rwxr-xr-x 1 root root 5753 Jan 4 20:59 linux.sh [1,2] lrwxrwxrwx 1 root root 8 Jan 29 02:20 setup.sh -> linux.sh [1,2,4] lrwxrwxrwx 1 root root 6 Jan 29 02:20 template -> ../tsp [3,4] -rw------- 1 root root 6547 Jan 4 20:59 tspc.conf Cheers, Jan. -- System Information: Debian Release: 3.1 APT prefers testing APT policy: (700, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.10 Locale: LANG=C, LC_CTYPE=cs_CZ.ISO-8859-2 (charmap=ISO-8859-2) Versions of packages tspc depends on: ii iproute 20041019-0.2 Professional tools to control the ii libc6 2.3.2.ds1-18 GNU C Library: Shared libraries an ii net-tools 1.60-10 The NET-3 networking toolkit -- no debconf information -- )^o-o^| jabber: [EMAIL PROTECTED] | .v K e-mail: jjminar FastMail FM ` - .' phone: +44(0)7981 738 696 \ __/Jan icq: 345 355 493 __|o|__Minář irc: [EMAIL PROTECTED]
pgpJJ07M2pWFK.pgp
Description: PGP signature
