On Sat, Jan 29, 2005 at 07:25:40PM +1100, Brendan O'Dea wrote:
>A broken declaration in show_entry_machine() causes this segfault:

Bother, it's more than just the decl.  Something strange with printf's
NULL handling.  This patch should work:

--bod

--- exif-0.6.9.orig/exif/actions.c      2004-05-26 07:52:57.000000000 +1000
+++ exif-0.6.9/exif/actions.c   2005-01-30 08:01:05.000000000 +1100
@@ -164,12 +164,12 @@
 show_entry_machine (ExifEntry *e, void *data)
 {
        unsigned char *ids = data;
-       char *v[1024];
+       char v[1024];
 
        if (*ids) fprintf (stdout, "0x%04x", e->tag);
        else fprintf (stdout, "%s", exif_tag_get_title (e->tag));
        printf ("\t");
-       fprintf (stdout, "%s", exif_entry_get_value (e, v, sizeof (v)));
+       fprintf (stdout, "%-.1024s", exif_entry_get_value (e, v, sizeof (v)));
        fputc ('\n', stdout);
 }
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to