On Wed, Jan 26, 2005 at 10:26:51AM -0500, Albert Cahalan wrote: > On Wed, 2005-01-26 at 12:33 +0100, Robert Millan wrote: > > On Tue, Jan 25, 2005 at 11:41:43PM -0500, Albert Cahalan wrote: > > > > In general I'm moving away from PAGE_SIZE, but I > > > sure do wish to keep it in minimal.c. Note that > > > this file is not compiled in by default, and that > > > it already supports FreeBSD. > > > > Well, currently it hardcoded PAGE_SIZE to 4096 when undefined. I think > > it's better to get it from system headers as FreeBSD (and GNU/kFreeBSD) > > have it =) > > Perhaps. Note that minimal.c is intended to work with > all sorts of wimpy C libraries: uClibc, klibc, newlib > Many of these libraries lack sysctl().
Then I suggest the code attempts to obtain PAGE_SIZE from system headers, and only if that fails, hardcode it to 4096 or whatever. I'd even issue a #warning in the latter case. > BTW, what C library are you using? Glibc. > Eeew. The BSDisms in glibc never fail to sicken me. > I've noticed that signal() is broken (it should map > to the Linux system call, which correctly follows the > 7th Edition and SysV behavior of unsetting the signal > handler when it is called). Also, fputs() does not > have the correct SysV return value. I sure wish the > glibc hackers would realize that, if I wanted BSD, I > would not be running Linux! Well, for other BSDisms like strlcpy/strlcat they have a different opinion. > Oh, I suppose, but can't you just implement SIGPWR? > All the real UNIX systems have it. > > There should be one signal left out. Find what it is. > Hopefully, the default action matches that of SIGPWR. > If so, then just call that SIGPWR. I could try.. but I'm not sure if FreeBSD upstream would accept a patch for that. I didn't see SIGPWR in any standard. Why don't you add a fallback case? -- .''`. Proudly running Debian GNU/kFreeBSD unstable/unreleased (on UFS2+S) : :' : `. `' http://www.debian.org/ports/kfreebsd-gnu `- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
