severity 291990 normal tags 291990 +pending thanks On Mon, Jan 24, 2005 at 05:33:31AM -0800, David Fox wrote: > Package: libblkid1 > Version: 1.35-8 > Severity: important > > There is a "quick format" option in windows to create an NTFS file system. > It does not zero out the partition, so it leaves enough magic around to let > blkid recognize the file system as reiserfs. (The magic numbers for reiserfs > appear at a substantial offset from the beginning, maybe 13K or more.) Since > the reiserfs cases appear before the NTFS cases in the libblkid code that > looks for magic numbers, the file system is identified as reiserfs instead of > ntfs. Moving the reiserfs cases down appears to fix the problem.
Thanks for pointing this out. This is really more of a Windows bug more than anything else, but it will be fixed in the next version of e2fsprogs. - Ted # This is a BitKeeper generated diff -Nru style patch. # # ChangeSet # 2005/01/25 03:26:10-05:00 [EMAIL PROTECTED] # probe.c: Windows can perform a "quick format" that doesn't clear # enough of the partition that the blkid probes can get # confused. Do the NTFS test first to deal with this # Windows misfeature. (Addresses Debian Bug #291990) # # lib/blkid/probe.c # 2005/01/25 03:26:10-05:00 [EMAIL PROTECTED] +1 -1 # probe.c: Windows can perform a "quick format" that doesn't clear # enough of the partition that the blkid probes can get # confused. Do the NTFS test first to deal with this # Windows misfeature. (Addresses Debian Bug #291990) # # lib/blkid/ChangeLog # 2005/01/25 03:26:10-05:00 [EMAIL PROTECTED] +7 -0 # Update log # diff -Nru a/lib/blkid/ChangeLog b/lib/blkid/ChangeLog --- a/lib/blkid/ChangeLog 2005-01-25 03:26:19 -05:00 +++ b/lib/blkid/ChangeLog 2005-01-25 03:26:19 -05:00 @@ -1,3 +1,10 @@ +2005-01-25 Theodore Ts'o <[EMAIL PROTECTED]> + + * probe.c: Windows can perform a "quick format" that doesn't clear + enough of the partition that the blkid probes can get + confused. Do the NTFS test first to deal with this + Windows misfeature. (Addresses Debian Bug #291990) + 2005-01-21 Theodore Ts'o <[EMAIL PROTECTED]> * probe.c (probe_oracleasm): Add support for recognizing Oracle diff -Nru a/lib/blkid/probe.c b/lib/blkid/probe.c --- a/lib/blkid/probe.c 2005-01-25 03:26:19 -05:00 +++ b/lib/blkid/probe.c 2005-01-25 03:26:19 -05:00 @@ -467,6 +467,7 @@ static struct blkid_magic type_array[] = { /* type kboff sboff len magic probe */ { "oracleasm", 0, 32, 8, "ORCLDISK", probe_oracleasm }, + { "ntfs", 0, 3, 8, "NTFS ", 0 }, { "jbd", 1, 0x38, 2, "\123\357", probe_jbd }, { "ext3", 1, 0x38, 2, "\123\357", probe_ext3 }, { "ext2", 1, 0x38, 2, "\123\357", probe_ext2 }, @@ -475,7 +476,6 @@ { "reiserfs", 64, 0x34, 9, "ReIsEr3Fs", probe_reiserfs }, { "reiserfs", 64, 0x34, 8, "ReIsErFs", probe_reiserfs }, { "reiserfs", 8, 20, 8, "ReIsErFs", probe_reiserfs }, - { "ntfs", 0, 3, 8, "NTFS ", 0 }, { "vfat", 0, 0x52, 5, "MSWIN", probe_vfat }, { "vfat", 0, 0x52, 8, "FAT32 ", probe_vfat }, { "vfat", 0, 0x36, 5, "MSDOS", probe_msdos }, -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]