Package: fwatch-modules-src
Version: 0.1-alpha-3
Severity: minor

Neither the package description nor the documentation in the
package states which kernel versions this module is supposed to
compile against.

I tried to build against kernel 2.6.10 (as part of a complete
kernel recompile) and it failed to build.  So I looked at the
documentation to see if there was some obvious explanation, but
found nothing resembling documentation in the package.

Also, the upstream URI in /usr/share/doc/fwatch-modules-src is
pretty useless (it is a volatile redirection URI at freshmeat).

I respectfully suggest the following packaging changes:

1. In the package description, state clearly which kernel
  versions this is designed for, something like (WARNING!!: The
  kernel version numbers and the "ftracker" feature in this
  sample text are fictive, as fwatch Debian Maintainer you
  probably know the correct values much better than I).
  
sample sample sample sample

Description: Kernel module source, reporting changes on files to /dev/fwatch
 This package provides the source code for the fwatch kernel module.
 
 This module is for kernel versions 2.4.41 to 2.4.45 and 2.6.25 to 2.6.27 it
 might also compile against later 2.4.x or 2.6.x kernels. It is not needed
 for kernel versions 2.8.x (those include the equivalent "ftracker"
 feature).
 
 The fwatch package is also required in order to make use of these
 modules. Kernel source is required to compile this module.

sample sample sample sample

2. In the rules file, fail appropriately if trying to compile
  against a known "bad" kernel version.  Only echo a warning if
  trying to compile against an untried but potentially good kernel
  version (such as one that was not available when the code was
  packaged).  For sample code, look at how others have packaged
  their kernel module sources, I am not sufficiently experienced in
  the specific innards of the kernel-package mechanics to provide
  policy-compliant code.

3. In /usr/share/doc/..../copyright, please use a more canonical
  upstream URI, preferably in close proximity to the upstream
  authors main project homepages www.fwatch.org and www.lincvs.org

4. In the absence of a real upstream README, include the original
  mailing list thread where Frank Hemer announces fwatch.
   (It is cached by google if you don't have a copy, just search
  for www.fwatch.org and Frank).
  
Respectfully (and moving on to other tasks...)

Jakob

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.18jbj3.1.64
Locale: LANG=C, LC_CTYPE=da_DK.utf-8 (charmap=UTF-8)

Versions of packages fwatch-modules-src depends on:
ii  debhelper                     4.2.30     helper programs for debian/rules
ii  module-assistant              0.7.2      tool to make module package creati

-- no debconf information


-- 
This message is hastily written, please ignore any unpleasant wordings,
do not consider it a binding commitment, even if its phrasing may
indicate so. Its contents may be deliberately or accidentally untrue.
Trademarks and other things belong to their owners, if any.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to