Hi

On Friday 21 January 2005 05:27, James A. Morrison wrote:
> Michael Niedermayer <[EMAIL PROTECTED]> writes:
> > Hi
> >
> > On Tuesday 18 January 2005 15:09, Philipp Matthias Hahn wrote:
> > > Hello!
> > >
> > > Please cc me on replies, because I'm no longer subscribed to
> > > ffmpeg-devel.
> > >
> > > While trying to build an uncastrated Debian ffmpeg package I stubled
> > > upon a problem when building ffmpeg outside the source tree:
> > >
> > > 1. The Makefile doesn't properly change to the libavcodex/libpostproc/
> > > directory in the build tree, but changes to the directory in the source
> > > tree. This is fixed by removing the '$(PATH)/' Prefix in
> > > libavcode/Makefile.
> > >
> > > 2. Building the manual pages in a separate build tree also doesn't
> > > work, since the doc/ directory isn't symlinked to the build tree. The
> > > converted manual pages are also explicitely referenced in the source
> > > tree, where they don't exist.
> > >
> > > 3. The quotation of "SRC_PATH='$source_path'" with single quotes is
> > > wrong in a Makefile, since the single quotes are used verbatim and are
> > > not shell meta characters.
> >
> > and removing them breaks compilation if there are spaces in the path
> >
> > [...]
> > --
> > Michael
>
>  This patch is a compromise.  For in-tree builds SRC_PATH='$source_path' is
> used, but for out-of-tree builds SRC_PATH=$source_path is used.  This patch
> has been tested by building ffmpeg on i386-linux both in tree with a space
> in the pathname and an out-of-tree build on i386-linux with no space in the
> pathname, I also tested this on sparc-linux in an out-of-tree build.
>
>  What doesn't work is an out-of-tree build with a space in the pathname.  I
> don't think this is something to worry about.  Most of the patch is by
> Phillip, I simply added the else and cleaned up DIRS and FILES so they fit
> in 80 characters.

applied

-- 
Michael

"nothing is evil in the beginning. Even Sauron was not so." -- Elrond


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to