Bug#283718: apt does not (always) honor the no_proxy environment variable

[Michael Vogt]

On Sun, Jan 09, 2005 at 02:03:07AM -0800, Matt Zimmerman wrote:
> On Tue, Nov 30, 2004 at 11:09:34PM +0100, Mario Lorenz wrote:
> 
> > Despite previous assertions to the contrary
> > (see eg. #118780), the no_proxy environment variable is not
> > always properly honored.
> 
> I believe mvo was looking into this.

Attached is a patch that solves the problem. 

But I keep wondering why the "putenv("no_proxy")" call is there in the
first place?

I tested the behaviour of this attached patch with squid and it works
fine.

thanks,
 Michael

-- 
Linux is not The Answer. Yes is the answer. Linux is The Question. - Neo

--- orig/methods/ftp.cc
+++ mod/methods/ftp.cc
@@ -1098,7 +1098,8 @@
         char S[300];
         snprintf(S,sizeof(S),"http_proxy=%s",getenv("ftp_proxy"));
         putenv(S);
-        putenv("no_proxy=");
+        //mvo: why should we unset no_proxy here?
+        //putenv("no_proxy=");
         
         // Run the http method
         string Path = flNotFile(argv[0]) + "http";