Package: cvsps
Version: 2.0rc1-4
Severity: normal
Tags: patch
The tm_isdst field in convert_date() is not initalized, it causes some
of the times to be calculated with daylight saving time and others
without. This causes patches to be ordered wrong and patchsets to be
broken apart. This bug could be the same as #267910.
I have marked this bug grave as it causes dataloss together with
cvs2darcs because of the wrongly ordered patches.
The initialization "tm.tm_isdst = 0;" should be added at line 188 of
util.c.
Regards,
Kim Hansen
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (700, 'unstable')
Architecture: i386 (i586)
Kernel: Linux 2.4.21-pre4
Locale: LANG=C, LC_CTYPE=da_DK (charmap=ISO-8859-1)
Versions of packages cvsps depends on:
ii cvs 1:1.12.9-9 Concurrent Versions System
ii libc6 2.3.2.ds1-20 GNU C Library: Shared libraries an
ii zlib1g 1:1.2.2-4 compression library - runtime
-- no debconf information
--- util.c.orig 2005-01-11 06:47:29.000000000 +0100
+++ util.c 2005-01-11 06:47:20.000000000 +0100
@@ -185,6 +185,7 @@
tm.tm_year -= 1900;
tm.tm_mon--;
+ tm.tm_isdst = 0;
*t = mktime(&tm);
}
