tags 285074 patch
severity 285074 important
thanks

On Fri, Jan 07, 2005 at 07:53:55AM -0330, Lawrence Williams wrote:
> I am working on packaging SDL 1.2.8. Among other things, I will disable 
> dlopen() so bugs like this won't occur.

I don't know what your timetable for the new version is, but in the
meantime, we worked this bug a bit at the BSP this weekend, and the attached
patch is the result.  This may be nothing different than what you already
had in mind, but I figured it wouldn't hurt to get it into the BTS.

In looking around at the source, I noticed that the alsa driver was not the
only one that had references to dlopen(); the esd and arts drivers also have
support for dlopen, only in the case of these two drivers, they *only*
support dlopen -- they are not linked against the underlying libs, and as a
result the packages are also missing dependencies on the packages providing
them!  I'm almost positive this is not the intended behavior -- AIUI, much
of the purpose of having split SDL audio packages is to ensure there's at
least one working audio driver -- but I didn't make any changes here without
confirming with you first.

I'm not NMUing for this bug at this time, because upon reflection, I think
this bug should be downgraded; and because the entire issue arose because of
a misbuild in the *maintainer's* build environment, so an NMU doesn't
actually fix that.  The chances of a security upload tripping across this
bug in testing or stable is very slim, and the immediate breakage in the
archive has already been fixed by a recompile-only NMU, so I don't think
there's any reason left to consider this RC.

OTOH, if it's determined that libsdl1.2debian-arts and libsdl1.2debian-esd
are missing dependencies on the corresponding audio libs, that would be an
RC bug.

Thanks,
-- 
Steve Langasek
postmodern programmer
diff -u libsdl1.2-1.2.7+1.2.8cvs20041007/debian/changelog 
libsdl1.2-1.2.7+1.2.8cvs20041007/debian/changelog
--- libsdl1.2-1.2.7+1.2.8cvs20041007/debian/changelog
+++ libsdl1.2-1.2.7+1.2.8cvs20041007/debian/changelog
@@ -1,3 +1,15 @@
+libsdl1.2 (1.2.7+1.2.8cvs20041007-3.1) unstable; urgency=high
+
+  * Non-maintainer upload
+  * High-urgency upload for sarge-targetted RC bugfix
+  * Add --disable-alsa-shared to the configure args: "shared" here means
+    "opened with libdl", not just "shared library", so the default
+    option gets us a needless duplicate reference to libasound -- and
+    sometimes to the *wrong* libasound.  Closes: #285074; thanks to
+    Brenda J. Butler for her help in tracking this down.
+
+ -- Steve Langasek <[EMAIL PROTECTED]>  Sun,  9 Jan 2005 20:32:47 -0800
+
 libsdl1.2 (1.2.7+1.2.8cvs20041007-3) unstable; urgency=medium
 
   * Fixed ALSA bug by increasing depends to 1.0.7-3 (Closes: 285074).
diff -u libsdl1.2-1.2.7+1.2.8cvs20041007/debian/rules 
libsdl1.2-1.2.7+1.2.8cvs20041007/debian/rules
--- libsdl1.2-1.2.7+1.2.8cvs20041007/debian/rules
+++ libsdl1.2-1.2.7+1.2.8cvs20041007/debian/rules
@@ -24,6 +24,7 @@
 
 
 CALLCFG=../$(TAR_DIR)/configure --enable-dlopen --prefix=/usr --with-pic \
+       --disable-alsa-shared \
        --build=$(DEB_BUILD_GNU_TYPE) --host=$(DEB_HOST_GNU_TYPE)
 
 MAKEFILE_INS:=$(shell find $(BUILD_DIR) -name Makefile.in)

Attachment: signature.asc
Description: Digital signature

Reply via email to