Your message dated Sun, 04 May 2025 18:23:39 +0000
with message-id <e1ube03-00guxq...@fasolo.debian.org>
and subject line Bug#1104235: fixed in libs3 2.0-4.1
has caused the Debian Bug report #1104235,
regarding Update debian/patches/utsn.patch for hurd-any
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1104235: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1104235
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: src:libs3
Version: 2.0-4
Severity: important
Tags: ftbfs patch
On Linux _UTSNAME_SYSNAME_LENGTH and _UTSNAME_MACHINE_LENGTH are 65,
and the platform string, which is defined as
char platform[_UTSNAME_SYSNAME_LENGTH + 1 + _UTSNAME_MACHINE_LENGTH];
fits into the subsequent snprintf command:
snprintf(userAgentG, sizeof(userAgentG),
"Mozilla/4.0 (Compatible; %s; libs3 %s.%s; %s)",
userAgentInfo, LIBS3_VER_MAJOR, LIBS3_VER_MINOR, platform);
where the target string is defined as:
#define USER_AGENT_SIZE 256
static char userAgentG[USER_AGENT_SIZE];
However, on Hurd _UTSNAME_SYSNAME_LENGTH and _UTSNAME_MACHINE_LENGTH
are 1024, and the compilation fails:
src/request.c:1105:57: error: ‘%s’ directive output may be truncated writing up
to 2048 bytes into a region of size between 211 and 218
[-Werror=format-truncation=]
1105 | "Mozilla/4.0 (Compatible; %s; libs3 %s.%s; %s)",
| ^~
1106 | userAgentInfo, LIBS3_VER_MAJOR, LIBS3_VER_MINOR, platform);
| ~~~~~~~~
src/request.c:1104:5: note: ‘snprintf’ output 40 or more bytes (assuming 2095)
into a destination of size 256
1104 | snprintf(userAgentG, sizeof(userAgentG),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1105 | "Mozilla/4.0 (Compatible; %s; libs3 %s.%s; %s)",
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1106 | userAgentInfo, LIBS3_VER_MAJOR, LIBS3_VER_MINOR, platform);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
The attached updated patch (intended to replace the current
debian/patches/utsn.patch has the following change:
-#define USER_AGENT_SIZE 256
+#define USER_AGENT_SIZE 126 + _UTSNAME_SYSNAME_LENGTH + _UTSNAME_MACHINE_LENGTH
This implies no change for Linux (126 + 65 + 65 = 256), but increases
the size to the appropriate size on Hurd.
diff -ur libs3-2.0.orig/src/request.c libs3-2.0/src/request.c
--- libs3-2.0.orig/src/request.c 2011-09-28 10:16:09.000000000 +0200
+++ libs3-2.0/src/request.c 2025-04-27 13:12:52.000000000 +0200
@@ -35,7 +35,7 @@
#include "util.h"
-#define USER_AGENT_SIZE 256
+#define USER_AGENT_SIZE 126 + _UTSNAME_SYSNAME_LENGTH + _UTSNAME_MACHINE_LENGTH
#define REQUEST_STACK_SIZE 32
static char userAgentG[USER_AGENT_SIZE];
@@ -1089,7 +1089,7 @@
userAgentInfo = "Unknown";
}
- char platform[96];
+ char platform[_UTSNAME_SYSNAME_LENGTH + 1 + _UTSNAME_MACHINE_LENGTH];
struct utsname utsn;
if (uname(&utsn)) {
strncpy(platform, "Unknown", sizeof(platform));
signature.asc
Description: This is a digitally signed message part
--- End Message ---
--- Begin Message ---
Source: libs3
Source-Version: 2.0-4.1
Done: Mattias Ellert <mattias.ell...@physics.uu.se>
We believe that the bug you reported is fixed in the latest version of
libs3, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1104...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mattias Ellert <mattias.ell...@physics.uu.se> (supplier of updated libs3
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 04 May 2025 19:12:41 +0200
Source: libs3
Architecture: source
Version: 2.0-4.1
Distribution: unstable
Urgency: medium
Maintainer: Laszlo Boszormenyi (GCS) <g...@debian.org>
Changed-By: Mattias Ellert <mattias.ell...@physics.uu.se>
Closes: 1104235
Changes:
libs3 (2.0-4.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Update debian/patches/utsn.patch for hurd-any (Closes: #1104235)
Checksums-Sha1:
b575ad9de955e3522d2c7acd6f3847a843981e63 1782 libs3_2.0-4.1.dsc
8c2a7fafdb4ea754a35def4df8ccf492ff06b35a 3432 libs3_2.0-4.1.debian.tar.xz
faad284687843141643a210215d1fa92db798efb 7848 libs3_2.0-4.1_amd64.buildinfo
Checksums-Sha256:
fb05ec8776f44accb2e7b7badb9b485d090402d97d7f6ef73040e7386b81bc0e 1782
libs3_2.0-4.1.dsc
31bf0372c8e716a90939a0445be7fa84b992c0151d58b7bb32774e9a8f6d6326 3432
libs3_2.0-4.1.debian.tar.xz
95b180b4d4f37c1ef41ef7d61482a1b3147385c5aeded30d86e7baf3eddecf54 7848
libs3_2.0-4.1_amd64.buildinfo
Files:
db4903625512e67e1dcc166e02ad77a0 1782 net optional libs3_2.0-4.1.dsc
30f3aa233be582b2d81c696938e55b54 3432 net optional libs3_2.0-4.1.debian.tar.xz
e91b0664cbd22c80f7f3e83c61e3ce2c 7848 net optional
libs3_2.0-4.1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE6hgwr99NQxrZ4RRS6K7C/zvhqUsFAmgXqlMACgkQ6K7C/zvh
qUv7WA/9Fi6W2G4BhqwgidXxeTglS4YUk7GstqB8+GMsnigx3zJntb0nL+jCYDTs
JRryaLS1CCtCstpTX2qcgN/dJ5/hXLiwMi6XDo3OESlNHuHCmj66TXVs/Pgn0utx
pxjmPmtvfQTAPJm9X3b8MeHfqIoSoReugjtM6/XviCc38f4qjQzBK8g5jG2vEmOo
Lc7+LRI2yLchiXd6SJOmUeOzdzBZj/SMBoxxZk4sIORaItCL9yK5gJGjdyM/8JjT
/IL/ocBorRl4Es0E2rifenZn97cLf/wSRLVoQHz7MXsRHOvCdhvRFO3GqZ+ogAP5
JUsEhev7yIvtdDBjLIq2XxNHz/Ve9N+gT8iIr+NNOOi69TYrXG+7WFtx7etHcQSH
AkOFFs/0K1ip9rvjDh57hBhzKHG2zYzWUdQRxCCIZ9sQ1kzc05+vU6R7CrTUZl+x
mohXkEP/8nz0AiZ/DReVGL2srzq6VIVRiXWlDEVNQ4Kf86VUsVq/5a5USqJyDmTw
B8ASm3QD/uChB/xYIL1hzUz5R1rxSu5Hg2ZZIPKAlndmKCxd6f1wupLoPs4WoMRc
XVgASjTLKjPih3mEgjuBTvZ8qeXpK/kB8SWr+VKAiHUu82mN1eSfMLNk6TjdUdg/
Ne7WU0yo5tOtvqu9h3XeCgBy7EDq/aLIuKsp21ab1vRg1gk42Ig=
=AG9P
-----END PGP SIGNATURE-----
pgpp_Diuhw1tq.pgp
Description: PGP signature
--- End Message ---
