Your message dated Tue, 22 Apr 2025 21:35:38 +0000
with message-id <e1u7lhg-009p0w...@fasolo.debian.org>
and subject line Bug#1103800: fixed in openvpn3-client 24+dfsg-2
has caused the Debian Bug report #1103800,
regarding openvpn3-client: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1103800: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1103800
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: openvpn3-client
Version: 24+dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
openvpn3-client could not be built reproducibly.

This is because it embedded both the build path and the current date.
Here's the date bit:

      ├── ./usr/share/bash-completion/completions/openvpn2
      │ @@ -1,12 +1,12 @@
      │  #
      │ -#  Copyright (C) 2017 - 2025  OpenVPN Inc <sa...@openvpn.net>
      │ +#  Copyright (C) 2017 - 2026  OpenVPN Inc <sa...@openvpn.net>

The absolute build path was embedded via a utility that was called via
its full path by meson, which then emitted its own path via printing
argv[0] ... which was saved to a file that was shipped in the .deb.

Patch attached that fixes both issues.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-



--- a/debian/patches/0003_reproducible-build.patch      1969-12-31 
16:00:00.000000000 -0800
--- b/debian/patches/0003_reproducible-build.patch      2025-04-21 
09:36:45.981672305 -0700
@@ -0,0 +1,55 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2025-04-21
+
+--- openvpn3-client-24+dfsg.orig/src/python/openvpn3/gen-python-constants.cpp
++++ openvpn3-client-24+dfsg/src/python/openvpn3/gen-python-constants.cpp
+@@ -29,6 +29,8 @@
+ #include "netcfg/netcfg-changetype.hpp"
+ #include "sessionmgr/sessionmgr-events.hpp"
+ 
++#include <openvpn/common/path.hpp>
++
+ 
+ enum class FlagType
+ {
+@@ -117,7 +119,7 @@ int main(int argc, char **argv)
+ {
+ 
+     std::cout << "#" << std::endl
+-              << "# Generated by " << argv[0] << std::endl
++              << "# Generated by " << openvpn::path::basename(argv[0]) << 
std::endl
+               << "# as part of the project build." << std::endl
+               << "#" << std::endl
+               << "# This file is part of openvpn3-linux, licensed" << 
std::endl
+--- 
openvpn3-client-24+dfsg.orig/src/shell/bash-completion/gen-openvpn2-completion.py
++++ 
openvpn3-client-24+dfsg/src/shell/bash-completion/gen-openvpn2-completion.py
+@@ -17,9 +17,12 @@
+ import importlib
+ import sys
+ import argparse
+-from datetime import date
++import os
++import time
++import datetime
+ from jinja2 import Template
+ 
++
+ completion_template = """#  OpenVPN 3 Linux client -- Next generation OpenVPN 
client
+ #
+ #  SPDX-License-Identifier: AGPL-3.0-only
+@@ -122,8 +125,13 @@ if __name__ == '__main__':
+         else:
+             valid_args[opt] = '%s' % values[0]
+ 
++    build_date = datetime.datetime.fromtimestamp(
++        int(os.environ.get('SOURCE_DATE_EPOCH', time.time())),
++        tz=datetime.timezone.utc,
++    )
++
+     ctpl = Template(completion_template)
+     script = ctpl.render(valid_args=valid_args, option_list=option_list,
+-                         year=date.today().year)
++                         year=build_date.year)
+ 
+     print(script)
--- a/debian/patches/series     2025-04-21 09:00:49.148735599 -0700
--- b/debian/patches/series     2025-04-21 09:24:09.687941086 -0700
@@ -1,2 +1,3 @@
 0001_import-unicode-impl-from-llvm.patch
 0002_fix-openvpn-to-_openvpn.patch
+0003_reproducible-build.patch

--- End Message ---
--- Begin Message ---
Source: openvpn3-client
Source-Version: 24+dfsg-2
Done: Marc Leeman <marc.lee...@gmail.com>

We believe that the bug you reported is fixed in the latest version of
openvpn3-client, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1103...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Marc Leeman <marc.lee...@gmail.com> (supplier of updated openvpn3-client 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 22 Apr 2025 10:50:56 +0200
Source: openvpn3-client
Binary: openvpn3-client openvpn3-client-dbgsym
Architecture: source amd64
Version: 24+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Marc Leeman <marc.lee...@gmail.com>
Changed-By: Marc Leeman <marc.lee...@gmail.com>
Description:
 openvpn3-client - virtual private network client (version 3)
Closes: 1103800
Changes:
 openvpn3-client (24+dfsg-2) unstable; urgency=medium
 .
   [ Fabio Pedretti ]
   * use proper project page
 .
   [ Marc Leeman ]
   * d/patches: make builds reproduceable (Closes: #1103800)
Checksums-Sha1:
 9b29ed2a58b9d13d15e4be14774a103538027dc9 2355 openvpn3-client_24+dfsg-2.dsc
 3d74007af4c8e33d07cf0705de88c10c5d289bf9 2569376 
openvpn3-client_24+dfsg.orig.tar.xz
 dd15641719c9373f0fbbacba3752707c8527283a 23432 
openvpn3-client_24+dfsg-2.debian.tar.xz
 22e9755365203db3aabc031872226e87c7cf6952 49471972 
openvpn3-client-dbgsym_24+dfsg-2_amd64.deb
 e849fc58b6cb1ddf681f5288c4867b337718e5a8 9516 
openvpn3-client_24+dfsg-2_amd64.buildinfo
 3d4388ccfa35fdd4a9f1742e729a69c25b3da70f 1926800 
openvpn3-client_24+dfsg-2_amd64.deb
Checksums-Sha256:
 be2182c69cac037d710fcb72ce166141908e6c75cdcba7c33a7a8872eb356b57 2355 
openvpn3-client_24+dfsg-2.dsc
 c1ac256a0ad5b96085ecd7037f2cb14655490da4705404e8fa99b052b1efb0f0 2569376 
openvpn3-client_24+dfsg.orig.tar.xz
 03230f924b93a3182cf0cc96e8abe1e849a2f036d5586b6009d873ce3ddfd8d0 23432 
openvpn3-client_24+dfsg-2.debian.tar.xz
 7b236d279140dc26660f9e716b7a4c78347f6b7adaaaac26b1e8a17980d353b4 49471972 
openvpn3-client-dbgsym_24+dfsg-2_amd64.deb
 6c3ce3a412d2eaf4e2e35d97fa5de799162169700538e03094b5e6ee3bb6e39b 9516 
openvpn3-client_24+dfsg-2_amd64.buildinfo
 b011877ee2933e9624ad7881596121719a00958b3039311ae49119a5e45fe38d 1926800 
openvpn3-client_24+dfsg-2_amd64.deb
Files:
 d6dc3370b234db99e77ca52e8f730a6d 2355 net optional 
openvpn3-client_24+dfsg-2.dsc
 576622485c33af52dab9de91b4e46a9f 2569376 net optional 
openvpn3-client_24+dfsg.orig.tar.xz
 89a8450d5a99afb0ed537b6a4657134f 23432 net optional 
openvpn3-client_24+dfsg-2.debian.tar.xz
 542a32430cc30638890365730947a50b 49471972 debug optional 
openvpn3-client-dbgsym_24+dfsg-2_amd64.deb
 02044e83c5ea26be714f6d667793fb80 9516 net optional 
openvpn3-client_24+dfsg-2_amd64.buildinfo
 76da73e8c807002079c1a112e6f6cd43 1926800 net optional 
openvpn3-client_24+dfsg-2_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE703UlH90QYpfEyJV58vhUqwX+XMFAmgIBdkACgkQ58vhUqwX
+XOk6xAAhwlTNljZXoV8u+rpv9gYrIm0ppmGCsGkxqdxp5M8oGS31Me1ykKGHRiQ
qFxUA0Dw6E7QGVtbFTlS14oEq1MqoACBeRhJ7FZSnnQNfBuo6T6C4ibI3wXEw9If
rh6XQYaAkRdl30DprXeTwZxiYeRVSk1ZAxB+QxkDu/lv0RHx6BvisNS4LeAv3RGp
ho69nTEMUc0pa5GD1v92H2TJYPReZi3oig5MaF5MmzRzlUW0oKj7Rqj9OHgki3at
9Eukdina3ptbzkXn2uw2/wKxgNjYAnsI0a0YyVtJTm4h0PJD91jti78RqD4uqMV7
CbQ/vLbmmWfoQHhWRU940/8F4e/1w0p+tgJ6krY637EX9WdkGztL06AY2yo0v4K9
ZKQFTbz4nqVSE2OE6kta+4e3Dup1kNK65dDHzvPnGT4/dfNSknZUTOhNUsadOihn
wHxNZp7qNc9dcqMDbPXoyFyfQBUjbAciL1R69PnpVkDJtoqBLBjbvLJqOX1MAIKa
H/Z19gv5++AMkSBy6s1LovND3GGF/aTZRW2HGHFbP3QEe9FkUzlmm/SQiWs7gov5
Apd51vhe3Gtoipz2JGGmsAqJt/QtXpGs2k/TbafaxWdcJiRUVIs6F3M+Zm4F8XzY
D1LzlAWmxsYH2SXmBNeWG7sh+znI8ts7/cIJDdj/KgA/0552fh0=
=RaoN
-----END PGP SIGNATURE-----

Attachment: pgp1Ex7ng_Ljb.pgp
Description: PGP signature


--- End Message ---

Reply via email to