Your message dated Tue, 03 Dec 2024 00:49:43 +0000
with message-id <e1tih6l-003hhb...@fasolo.debian.org>
and subject line Bug#941191: fixed in gigalomania 1.0+ds1-1.2
has caused the Debian Bug report #941191,
regarding gigalomania FTCBFS: uses build architecture build tools
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
941191: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=941191
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: gigalomania
Version: 1.0+ds1-1
Tags: patch
User: debian-cr...@lists.debian.org
Usertags: ftcbfs

gigalomania fails to cross build from source, because it uses build
architecture build tools. The easiest way of passing cross tools to make
- using dh_auto_build - doesn't fully work here, because gigalomania's
Makefile uses CC for the C++ compiler. The variable needs to be renamed.
Also debian/rules hard codes the build architecture pkg-config.
Supplying a pkg-config from dpkg's buildtools.mk fixes this part. Please
consider applying the attached patch.

Helmut
diff --minimal -Nru gigalomania-1.0+ds1/debian/changelog 
gigalomania-1.0+ds1/debian/changelog
--- gigalomania-1.0+ds1/debian/changelog        2018-03-11 09:48:27.000000000 
+0100
+++ gigalomania-1.0+ds1/debian/changelog        2019-09-26 05:57:14.000000000 
+0200
@@ -1,3 +1,13 @@
+gigalomania (1.0+ds1-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Let dh_auto_build pass cross tools to make.
+    + Rename the C++ compiler to CC.
+    + Use a pkg-config from dpkg's buildtools.mk in d/rules.
+
+ -- Helmut Grohne <hel...@subdivi.de>  Thu, 26 Sep 2019 05:57:14 +0200
+
 gigalomania (1.0+ds1-1) unstable; urgency=medium
 
   * Initial release. (Closes: #865784)
diff --minimal -Nru gigalomania-1.0+ds1/debian/rules 
gigalomania-1.0+ds1/debian/rules
--- gigalomania-1.0+ds1/debian/rules    2018-03-11 09:48:27.000000000 +0100
+++ gigalomania-1.0+ds1/debian/rules    2019-09-26 05:57:14.000000000 +0200
@@ -1,6 +1,8 @@
 #!/usr/bin/make -f
 
 export DH_VERBOSE=1
+-include /usr/share/dpkg/buildtools.mk
+PKG_CONFIG?=pkg-config
 CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS)
 #CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS) $(CPPFLAGS)
 LDFLAGS:=$(shell dpkg-buildflags --get LDFLAGS)
@@ -9,10 +11,10 @@
        dh $@
 
 override_dh_auto_build:
-       $(MAKE) DATADIR="/usr/share/gigalomania" \
-       CCFLAGS="-g -O2 -Wall $(CPPFLAGS)" \
+       dh_auto_build -- DATADIR="/usr/share/gigalomania" \
+       CC='$$(CXX)' CCFLAGS="-g -O2 -Wall $(CPPFLAGS)" \
        LINKPATH="$(LDFLAGS) `sdl2-config --libs` -L/usr/X11R6/lib/ -L/usr/lib" 
\
-       LIBS="-lSDL2_image -lSDL2_mixer `pkg-config --libs tinyxml`" all
+       LIBS="-lSDL2_image -lSDL2_mixer `$(PKG_CONFIG) --libs tinyxml`" all
 
 override_dh_auto_install:
        $(MAKE) DESTDIR="$(CURDIR)/debian/tmp/gigalomania" \

--- End Message ---
--- Begin Message ---
Source: gigalomania
Source-Version: 1.0+ds1-1.2
Done: Alexandre Detiste <tc...@debian.org>

We believe that the bug you reported is fixed in the latest version of
gigalomania, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 941...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alexandre Detiste <tc...@debian.org> (supplier of updated gigalomania package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 03 Dec 2024 01:18:20 +0100
Source: gigalomania
Architecture: source
Version: 1.0+ds1-1.2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-de...@lists.alioth.debian.org>
Changed-By: Alexandre Detiste <tc...@debian.org>
Closes: 941191
Changes:
 gigalomania (1.0+ds1-1.2) unstable; urgency=medium
 .
   * Team Upload
   * Set Rules-Requires-Root: no
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: (Closes: #941191)
     + Let dh_auto_build pass cross tools to make.
     + Rename the C++ compiler to CC.
     + Use a pkg-config from dpkg's buildtools.mk in d/rules.
Checksums-Sha1:
 43c323ea674f7ee7b3c34a373142c2dfd500479a 2151 gigalomania_1.0+ds1-1.2.dsc
 f7fc532aa21e82480aa4fc2dfc959b7adbfdf0c9 342160 
gigalomania_1.0+ds1-1.2.debian.tar.xz
 fba11114c92a83f2575c44c6cdf1b04c2932b7d8 13669 
gigalomania_1.0+ds1-1.2_source.buildinfo
Checksums-Sha256:
 67e91d0946b84cc6de333d31fd9a46685c3a5d250d2d82dcc9d7331e9d815c1f 2151 
gigalomania_1.0+ds1-1.2.dsc
 c4b798f2bf8981734e9fed6cb8aef32163a76ef2b2c20f92d23ecc6d86b175bc 342160 
gigalomania_1.0+ds1-1.2.debian.tar.xz
 24535a4c918249d6d5dbb1eba3df229a260bdf3f613ed1cb259608f7f4c15c0b 13669 
gigalomania_1.0+ds1-1.2_source.buildinfo
Files:
 0fc66ee58b6d73ede56c650eba55b2f6 2151 games optional 
gigalomania_1.0+ds1-1.2.dsc
 fdbfd5a7b777513b5b21898f951a6cad 342160 games optional 
gigalomania_1.0+ds1-1.2.debian.tar.xz
 2c8431bd069ce7f76cc8a4a5af9570ac 13669 games optional 
gigalomania_1.0+ds1-1.2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEj23hBDd/OxHnQXSHMfMURUShdBoFAmdOT4gRHHRjaGV0QGRl
Ymlhbi5vcmcACgkQMfMURUShdBoxuBAAkUwaTAzgOr0ue7YIbCCl9TNg4I8SyxaL
knOIoJuu5OoNCy2vkxCbyiDWG0wiRfEHlxn9u77FS67jgWofJD6TV7YXfc4JX1e1
vAKPVaGJm7vEHQbqd6nlPJNUlSRM292JBONasJYg1sGNsnJNVWFW3mpXe5IVCU+r
LXCTDFZ+i3KojDDk5aRacKPam9pmnWtCwa1OiESWWiv9dNKX842IUSuvAXLDT5gi
TsjJiFdEXMVLmn/ZLQ85rVr67kOSRi3nrWuPaG3pHIdeKgd2Wol4et5IouFLVqyQ
Lwe7Cpnomp4UGqLpm/lNmB5Gfo0KGXiD+QSEMeBWU9Cpe1CxtwijNUTR3zjXhPTX
lKsDpgWXGctRfVG2A9qVoSIlTcurz9LqUgUYKTIWaLStAlIEm1Rep7VTTIs3Aq9x
Y+zHqDoXc4bEm74Lc4L/l8/gY0RTQI1AxIHWBwYLoz68tKAJ0reH9QrXkae0GUo6
JBmZwrOWlO8UHutVEGczJRUPt1zSRd1y6ftJbbbss2+6xlWcshJr4eo+XXPW7RmT
MJ217eHepaZQ2hXdA1IrlTcOqXUcjJU1lfOeh3W1FlysXfHuJCD6eTkHibNU4xbF
Fdxli0T9rxOf4Emjnvw455PvTJwtiBQ5g98AMZVxi3j4CepeWjIGrDIyH9xjhSs8
wAuBxxBWaWM=
=gFmS
-----END PGP SIGNATURE-----

Attachment: pgpVZBDg_1Wb6.pgp
Description: PGP signature


--- End Message ---

Reply via email to