Bug#911331: marked as done (ploticus: randomly fails drawing lines)

Wed, 16 Oct 2024 03:03:18 -0700 

Your message dated Wed, 16 Oct 2024 10:00:29 +0000
with message-id <e1t10pr-00dkit...@fasolo.debian.org>
and subject line Bug#911331: fixed in ploticus 2.42-8
has caused the Debian Bug report #911331,
regarding ploticus: randomly fails drawing lines
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
911331: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911331
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message --- 
Package: ploticus
Version: 2.42-4
Severity: important
Tags: patch upstream

Dear Maintainer,

Lines are sometimes drawn with one end extending to lower left. Rendering the
same input might usually look fine, but fail randomly. Example input and output
of 100 iterations attached.

The cause seems to be reading outside of allocated memory
on line execline.c:489. This leads to a wrong argument count causing the
following warning:

pl proc line:  2959: warning: points must have either 4 or 2 values per line



-- System Information:
Debian Release: buster/sid
  APT prefers bionic-updates
  APT policy: (500, 'bionic-updates'), (500, 'bionic-security'), (500,
'bionic'), (100, 'bionic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-36-generic (SMP w/3 CPU cores)
Locale: LANG=fi_FI.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8),
LANGUAGE=fi_FI.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages ploticus depends on:
ii  libc6     2.27-3ubuntu1
ii  libgd3    2.2.5-4ubuntu0.2
ii  libx11-6  2:1.6.4-3ubuntu0.1
ii  zlib1g    1:1.2.11.dfsg-0ubuntu2

ploticus recommends no packages.

ploticus suggests no packages.

#proc page
  dopagebox: yes
  pagesize: 3.380 0.600

#proc areadef
  rectangle: 0.010 0.010 3.37 0.59
  yscaletype: linear
  yrange: 0 60
  xscaletype: linear
  xrange: 0.999 2.000
  #saveas: A

#proc legendentry
  sampletype: color
  details: rgb(0,0.6,0)
  tag: barcoldefault

#proc legendentry
  sampletype: color
  details: black
  tag: black

#proc legendentry
  sampletype: color
  details: rgb(0.9,0.3,0.3)
  tag: dummy0

#proc legendentry
  sampletype: color
  details: rgb(0.9,0.3,0.3)
  tag: dummy1

#proc legendentry
  sampletype: color
  details: rgb(0.9,0.3,0.3)
  tag: dummy2

#proc legendentry
  sampletype: color
  details: rgb(0.9,0.3,0.3)
  tag: dummy3

#proc legendentry
  sampletype: color
  details: rgb(0.9,0.3,0.3)
  tag: dummy4

#proc legendentry
  sampletype: color
  details: rgb(0.9,0.3,0.3)
  tag: dummy5

#proc legendentry
  sampletype: color
  details: gray(0.0)
  tag: s

#proc legendentry
  sampletype: color
  details: rgb(0.9,0.3,0.3)
  tag: sx

#proc legendentry
  sampletype: color
  details: gray(0.5)
  tag: textcol

#proc legendentry
  sampletype: color
  details: gray(1)
  tag: w

#proc legendentry
  sampletype: color
  details: gray(0.999)
  tag: white

#proc legendentry
  sampletype: color
  details: rgb(1,0.7,0.7)
  tag: wx




#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 0.050 0(s)+0.05 0.050 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 0.095 0(s)+0.05 0.095 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 0.170 0(s)+0.05 0.170 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 0.215 0(s)+0.05 0.215 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 0.530 0(s)+0.05 0.530 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 0.575 0(s)+0.05 0.575 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 0.650 0(s)+0.05 0.650 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 0.695 0(s)+0.05 0.695 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 1.010 0(s)+0.05 1.010 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 1.055 0(s)+0.05 1.055 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 1.130 0(s)+0.05 1.130 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 1.175 0(s)+0.05 1.175 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 2.450 0(s)+0.05 2.450 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 2.495 0(s)+0.05 2.495 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 2.570 0(s)+0.05 2.570 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 2.615 0(s)+0.05 2.615 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 2.930 0(s)+0.05 2.930 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 2.975 0(s)+0.05 2.975 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 3.050 0(s)+0.05 3.050 60(s)-0.05
#proc line
  linedetails: width=10 color=rgb(1,0.7,0.7) style=0
  points: 3.095 0(s)+0.05 3.095 60(s)-0.05
#proc line
  linedetails: width=0.2 color=black style=0
  points: 0.010 2(s)+0.001 0.010 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 0.250 2(s)+0.001 0.250 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 0.490 2(s)+0.001 0.490 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 0.730 2(s)+0.001 0.730 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 0.970 2(s)+0.001 0.970 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 1.210 2(s)+0.001 1.210 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 1.450 2(s)+0.001 1.450 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 1.690 2(s)+0.001 1.690 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 1.930 2(s)+0.001 1.930 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 2.170 2(s)+0.001 2.170 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 2.410 2(s)+0.001 2.410 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 2.650 2(s)+0.001 2.650 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 2.890 2(s)+0.001 2.890 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 3.130 2(s)+0.001 3.130 60(s)-0.001
#proc line
  linedetails: width=0.2 color=black style=0
  points: 3.370 2(s)+0.001 3.370 60(s)-0.001
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 0.220 24(s)+0.03 0.220 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 0.280 24(s)+0.03 0.280 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 0.460 24(s)+0.03 0.460 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 0.520 24(s)+0.03 0.520 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 0.940 24(s)+0.03 0.940 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 1.000 24(s)+0.03 1.000 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 1.180 24(s)+0.03 1.180 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 1.240 24(s)+0.03 1.240 60(s)-0.03
#proc line
  linedetails: width=6 color=rgb(0.9,0.3,0.3) style=0
  points: 1.420 24(s)+0.03 1.420 60(s)-0.03
#proc line
  linedetails: width=6 color=rgb(0.9,0.3,0.3) style=0
  points: 1.480 24(s)+0.03 1.480 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 1.900 24(s)+0.03 1.900 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 1.960 24(s)+0.03 1.960 60(s)-0.03
#proc line
  linedetails: width=6 color=rgb(0.9,0.3,0.3) style=0
  points: 2.140 24(s)+0.03 2.140 60(s)-0.03
#proc line
  linedetails: width=6 color=rgb(0.9,0.3,0.3) style=0
  points: 2.200 24(s)+0.03 2.200 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 2.620 24(s)+0.03 2.620 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 2.680 24(s)+0.03 2.680 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 2.860 24(s)+0.03 2.860 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 2.920 24(s)+0.03 2.920 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 3.100 24(s)+0.03 3.100 60(s)-0.03
#proc line
  linedetails: width=6 color=gray(0.0) style=0
  points: 3.160 24(s)+0.03 3.160 60(s)-0.03
#proc line
  linedetails: width=0.2 color=black style=0
  points: 0.011 2(s) 3.369 2(s)
#proc line
  linedetails: width=0.2 color=black style=0
  points: 0.011 59(s) 3.369 59(s)


#proc annotate
  location: 0.08 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: c

#proc annotate
  location: 0.32 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: d

#proc annotate
  location: 0.56 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: e

#proc annotate
  location: 0.8 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: f

#proc annotate
  location: 1.04 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: g

#proc annotate
  location: 1.28 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: a

#proc annotate
  location: 1.52 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: b

#proc annotate
  location: 1.76 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: c

#proc annotate
  location: 2 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: d

#proc annotate
  location: 2.24 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: e

#proc annotate
  location: 2.48 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: f

#proc annotate
  location: 2.72 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: g

#proc annotate
  location: 2.96 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: a

#proc annotate
  location: 3.2 0.04
  textdetails: align=center size=8 color=gray(0.5)
  text: b







#endproc

diff --git a/pl241src/src/execline.c b/pl241src/src/execline.c
index b733c74..63d5675 100644
--- a/pl241src/src/execline.c
+++ b/pl241src/src/execline.c
@@ -457,7 +457,7 @@ txtstartline = PLL.curline;
 txtlen = strlen( firstline );
 
 /* go until we hit an empty line, or reach end of proc.. */
-for( iline = txtstartline; iline <= procstop ; iline++ ) {
+for( iline = txtstartline; iline < procstop ; iline++ ) {
        line = PLL.procline[ iline ];
        for( i = 0, emptyline = 1; line[i] != '\0'; i++ ) if( !isspace( (int) 
line[i] )) { emptyline = 0; break; }
        if( emptyline ) break;
@@ -485,7 +485,7 @@ if( firstline[i] != '\0' ) {
 
 
 /* now fill mem.. */
-for( iline = txtstartline; iline < txtstopline && iline <= procstop; iline++ ) 
{
+for( iline = txtstartline; iline < txtstopline; iline++ ) {
        line = PLL.procline[ iline ];
        
        /* skip over leading whitespace as well as any leading backslash.. */
diff --git a/pl241src/src/proc_line.c b/pl241src/src/proc_line.c
index 166321f..af41aad 100644
--- a/pl241src/src/proc_line.c
+++ b/pl241src/src/proc_line.c
@@ -19,7 +19,7 @@ int lvp, first;
 
 char buf[256];
 double x, y, ancx, ancy;
-char *linedetails, *drawpoints;
+char *linedetails, *drawpoints = NULL;
 char notation;
 char a[40], b[40], c[40], d[40];
 int nt, ix, buflen, ancgiven;

--- End Message ---
--- Begin Message --- 
Source: ploticus
Source-Version: 2.42-8
Done: Shengqi Chen <harry-c...@outlook.com>

We believe that the bug you reported is fixed in the latest version of
ploticus, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 911...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Shengqi Chen <harry-c...@outlook.com> (supplier of updated ploticus package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 16 Oct 2024 17:02:57 +0800
Source: ploticus
Architecture: source
Version: 2.42-8
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packa...@qa.debian.org>
Changed-By: Shengqi Chen <harry-c...@outlook.com>
Closes: 911331 960225
Changes:
 ploticus (2.42-8) unstable; urgency=medium
 .
   * QA upload.
   * d/rules:
     + migrate from hand-written rules to dh sequence (closes: #960225)
     + enable all hardening flags, compile with C99
     + disable DH_VERBOSE by default
   * d/patches:
     + add Forwarded header to all patches
     + add patch to fix OOB memory access (closes: #911331)
     + add more fixes to man-fix.patch
   * d/watch: update version & use https
   * Add necessary dependencies to shared library
   * Add lintian-overrides for libploticus0
Checksums-Sha1:
 8ef558ecd24b4ed3db8b3b0bf7589644d6d321dd 1717 ploticus_2.42-8.dsc
 f26c904b6ce2cec18372cbe9b7a6e3639ae58633 19732 ploticus_2.42-8.debian.tar.xz
 bedca7e806301d39b76bd2d25bd85ea3a77d4f29 6371 ploticus_2.42-8_source.buildinfo
Checksums-Sha256:
 379f3b3d88398bce535b194ecc955c9952cb9320003ed110155a222525a20952 1717 
ploticus_2.42-8.dsc
 f888a01034c1580881227ef112aa2db4bec6fdb3a4f56dd05871a3de89299710 19732 
ploticus_2.42-8.debian.tar.xz
 69914940254d6918130ffd8720acc7ec12837f60254059ef6f819a72e22399ac 6371 
ploticus_2.42-8_source.buildinfo
Files:
 3c5acd4ce258dbbc5e29dd45423ef95c 1717 misc optional ploticus_2.42-8.dsc
 b528b5ec6ea2768a1b1795b825a157ef 19732 misc optional 
ploticus_2.42-8.debian.tar.xz
 7a7a5cd19f831210c4b8fe1774328607 6371 misc optional 
ploticus_2.42-8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEBLHAyuu1xqoC2aJ5NP8o68vMTMgFAmcPh9AACgkQNP8o68vM
TMjxewf/UKx/PqkXS7Cnrl94w7wOC1dYB90UmvKBIleH9v5BFDh9h0m/w94jhDk6
f8RbFlnz3IF0EIYUJmb/IE7qn8pV5NHP6D/+b1DrS4FyqwOkCUllmvgByBEX0yni
56Nz2mIZEClp0VSfu+HT4IT5DCvJ47vIyB0ARPMAMfeZArzcR9rPy/FrRYd4vem6
24vrCntden/822ZhkGOVjX6kSPXxfkDMLCc9JxoUWZ9MwQxf7+mJ4knbdn+ZogWO
RJML82YEX6kU6xq9KX2iTSrue/5z29WKjLAsirrVpVY5G3uMPl1Mmv9Bfi6Tuf46
CA+toM/eIVjnVvi7/hoZmr18yLdBzg==
=fxxm
-----END PGP SIGNATURE-----

Attachment: pgp7lkTTIEfi8.pgp
Description: PGP signature


--- End Message ---

Reply via email to