Your message dated Tue, 22 Aug 2023 19:24:55 +0000
with message-id <e1qywzn-00dvyw...@fasolo.debian.org>
and subject line Bug#977183: fixed in zpspell 0.4.3-5
has caused the Debian Bug report #977183,
regarding zpspell FTCBFS: uses an unsupported pkg-config integration
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
977183: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977183
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: zpspell
Version: 0.4.3-4.1
Tags: patch upstream
User: debian-cr...@lists.debian.org
Usertags: ftcbfs

zpspell fails to cross build from source, because it uses an unsupported
cmake <-> pkg-config integration mechanism. cmake even warns about that
and during cross builds it fails to find the relevant packages. Please
consider applying the attached patch to use the industry-standard
pkg-config integration, which happens to just work for cross compilation
and doesn't spill warnings during build.

Helmut
--- zpspell-0.4.3.orig/CMakeLists.txt
+++ zpspell-0.4.3/CMakeLists.txt
@@ -37,71 +37,13 @@
 
 
 # dbus and glib stuff
-include(UsePkgConfig)
-pkgconfig("dbus-glib-1" _dbusIncDir _dbusLinkDir _dbusLinkFlags _dbusCflags)
-pkgconfig("glib-2.0" _glibIncDir _glibLinkDir _glibLinkFlags _glibCflags)
-
-# DBUS_INCLUDE_DIR
-find_path(DBUS_INCLUDE_DIR dbus/dbus-glib.h
-   ${_dbusIncDir}
-   ${_dbusIncDir}/dbus-1.0
-   /usr/include/dbus-1.0
-   /usr/include
-   /usr/local/include/dbus-1.0
-   /usr/local/include
-)
-# DBUS_LIBRARY
-find_library(DBUS_LIBRARY NAMES dbus-1
-    PATHS
-    ${_dbusLinkDir}
-    /usr/lib
-    /usr/local/lib
-)
-
-# GLIB2_INCLUDE_DIR
-find_path(GLIB2_INCLUDE_DIR glib.h
-   ${_glibIncDir}
-   /usr/include
-   /usr/include/glib-2.0
-   /usr/local/include
-)
-# GLIB2_LIBRARY
-find_library(GLIB2_LIBRARY NAMES glib-2.0
-    PATHS
-    ${_glibLinkDir}
-    /usr/lib
-    /usr/local/lib
-)
-# GLIB_CONFIG
-find_path(GLIB_CONFIG_DIR glibconfig.h
-   ${_glibLinkDir}/glib-2.0/include
-   ${_glibLinkDir}/glib-2.0
-   /usr/lib/glib-2.0/include
-   /usr/lib/glib-2.0
-   /usr/include/glib-2.0
-   /usr/local/include
-)
-
-
-if(DBUS_LIBRARY AND DBUS_INCLUDE_DIR)
-        message(STATUS "Found DBUS_LIBRARY: ${DBUS_LIBRARY}")
-        message(STATUS "Found DBUS_INCLUDE_DIR: ${DBUS_INCLUDE_DIR}")
-else(DBUS_LIBRARY AND DBUS_INCLUDE_DIR)
-        message(FATAL_ERROR "Can't find DBUS")
-endif(DBUS_LIBRARY AND DBUS_INCLUDE_DIR)
-
-if(GLIB2_LIBRARY AND GLIB2_INCLUDE_DIR)
-        message(STATUS "Found GLIB2_LIBRARY: ${GLIB2_LIBRARY}")
-        message(STATUS "Found GLIB2_INCLUDE_DIR: ${GLIB2_INCLUDE_DIR}")
-else(GLIB2_LIBRARY AND GLIB2_INCLUDE_DIR)
-        message(FATAL_ERROR "Can't find DBUS")
-endif(GLIB2_LIBRARY AND GLIB2_INCLUDE_DIR)
-
+include(FindPkgConfig)
+pkg_check_modules(DBUS_GLIB REQUIRED "dbus-glib-1")
+pkg_check_modules(GLIB REQUIRED "glib-2.0")
 
 # include and link...
-include_directories(${DBUS_INCLUDE_DIR})
-include_directories(${GLIB2_INCLUDE_DIR})
-include_directories(${GLIB_CONFIG_DIR})
+include_directories(${DBUS_GLIB_INCLUDE_DIRS})
+include_directories(${GLIB_INCLUDE_DIRS})
 
-target_link_libraries(zpspell glib-2.0 dbus-glib-1 gobject-2.0)
+target_link_libraries(zpspell ${GLIB_LIBRARIES} ${DBUS_GLIB_LIBRARIES})
 

--- End Message ---
--- Begin Message ---
Source: zpspell
Source-Version: 0.4.3-5
Done: Bastian Germann <b...@debian.org>

We believe that the bug you reported is fixed in the latest version of
zpspell, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 977...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Germann <b...@debian.org> (supplier of updated zpspell package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 22 Aug 2023 13:49:06 +0000
Source: zpspell
Architecture: source
Version: 0.4.3-5
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packa...@qa.debian.org>
Changed-By: Bastian Germann <b...@debian.org>
Closes: 977183 1031995
Changes:
 zpspell (0.4.3-5) unstable; urgency=medium
 .
   * QA upload.
   * Drop Vcs fields. (Closes: #1031995)
   * Convert to source format 3.0 (quilt).
 .
   [ Helmut Grohne ]
   * Use standard pkg-config integration. (Closes: #977183)
Checksums-Sha1:
 48de9eda49be877f3fecb494bcf4c7903b557e61 1562 zpspell_0.4.3-5.dsc
 89efff71deb35c66d89a69a976efd0db85f397a1 4656 zpspell_0.4.3-5.debian.tar.xz
 211b721dd2f922c988d762fd54aba0b6b8c61ee4 7424 zpspell_0.4.3-5_source.buildinfo
Checksums-Sha256:
 0b812f92a0d1d5558f92f7d21c81e3cd35343c67425d06748c6877f3e6c4822f 1562 
zpspell_0.4.3-5.dsc
 c8273ed0a1bc0e5a09f039c3c254f17e1781db2fa683d55f8695e6a85d67c45f 4656 
zpspell_0.4.3-5.debian.tar.xz
 42ba0ebb65610e442f82eadcfebed3dc774cc73ca915fd76f0aa2f31f2e9d5d6 7424 
zpspell_0.4.3-5_source.buildinfo
Files:
 fb25de7c413d6c25576d98205e9bc482 1562 text optional zpspell_0.4.3-5.dsc
 b982fe68c08595461dbac670e92f2316 4656 text optional 
zpspell_0.4.3-5.debian.tar.xz
 04ee9d2dfb925a887e3b8810db78803d 7424 text optional 
zpspell_0.4.3-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmTlANYQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFP01C/wNQ9m/JEgTm7EhwExADvHeZbE1b6JXTQSi
jw5fizI5+zVW84iTPA2mJIdsOeWcFzTVNfcckuxQhVE+G/OnKX9eWXunczlbfS2W
hpfvLL/NBxP8LC70X+EfRO3k2UKbWcaoR8k1Xa50eb8syY6Kl6cB3esAwltZUCP4
BoPSkqsxxrwFlAe7gGAHBLMuZE2bjFd/7BEniHO8CqJMr0F988Ls6KnEcqzWEq5i
cGLo4CCjPXzDyNg+0oNJFxQDhC8rWJZFEL4+wOgV1bXtIOyUepj2sSWnq3o3WNWo
50gsbiytqg8P8UMjKl3ENhLO+V90p/G9sPW/AQCGk/p5hm/+uRoB2PvFesKD6MDv
IFuJt96kcTsnZJtUQYzfJUrbhzdVu5ZR/jntydh6OC0STKtr79PUpk57HM5hpPc5
v1htRseDpc8UB94fkzZJKyljpCs7n0hMkr7ffGfi3kgT83cKvIW/TM+2pZVY3m99
OzvVfCWF67XfnIFtYU7w2tZkq2hBMpg=
=W4RB
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to