Your message dated Tue, 22 Aug 2023 13:22:42 +0000
with message-id <e1qyrlg-00brvi...@fasolo.debian.org>
and subject line Bug#1022837: fixed in runit 2.1.2-56
has caused the Debian Bug report #1022837,
regarding /lib/runit/run_sysv_scripts uses wrong test to skip initscripts
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1022837: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1022837
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: runit
Version: 2.1.2-50
Severity: normal
Hi,
/lib/runit/run_sysv_scripts has this:
for script in "$initdir/$rX"* ; do
[ ! -x "$script" ] && continue
path=$(realpath "$script")
name=${path##*/}
# Special case for wicd. Runscript is called "wicd-daemon",
# to match binary package name.
[ -d "/etc/sv/$name" ] && continue
[ -d "/etc/sv/$name-daemon" ] && continue
"$script" "$rcommand"
done
Checking for /etc/sv/$name and skipping initscripts if those directories exist
is wrong for two reasons:
1. /etc/sv/$name may not be symlinked into /etc/service (false positive);
2. /etc/service may contain a symlink to a service directory for this service
that is elsewhere in the filesystem, not in /etc/sv (false negative).
As a minimum, I suggest the following: instead of /etc/sv/$name, check for
/etc/service/$name (and $name-daemon if necessary), and not with "-d" but "-L"
(because when running rcS.d, the target of the symlink may only appear later,
for example when a new filesystem is mounted).
This is still imperfect during boot because /etc/service may point to some
directory that is not the one we'll switch to with runsvdir in stage 2. I don't
know what the best way of handling this (likely rare) case is, but the
following solutions come to mind:
1. have a /etc/runit/override-init.d/ directory. If $name exists in it, don't
invoke the initscript in /lib/runit/run_sysv_scripts. This places the entire
administration/configuration burden on the admin but is very simple to do, and
easy enough for the admin to automate (e.g. your own service scripts can just
create these files when they're first run).
2. pass the name of the /etc/runit/runsv directory that we expect to be used
to /lib/runit/run_sysv_scripts somehow (for example, in an environment
variable). This looks brittle (riddled with race conditions) and complicated to
me, but it would require no effort from the admin.
3. invoke runsvchdir earlier during boot. This is problematic on systems where
/ is read-only before some initscripts are run.
4. [other kludges]
András
--
Reality is merely an illusion, albeit a very persistent one.
--- End Message ---
--- Begin Message ---
Source: runit
Source-Version: 2.1.2-56
Done: Lorenzo Puliti <plore...@disroot.org>
We believe that the bug you reported is fixed in the latest version of
runit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1022...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lorenzo Puliti <plore...@disroot.org> (supplier of updated runit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 17 Aug 2023 19:36:41 +0200
Source: runit
Built-For-Profiles: noudeb
Architecture: source
Version: 2.1.2-56
Distribution: experimental
Urgency: medium
Maintainer: Lorenzo Puliti <plore...@disroot.org>
Changed-By: Lorenzo Puliti <plore...@disroot.org>
Closes: 1022837 1043419 1046998
Changes:
runit (2.1.2-56) experimental; urgency=medium
.
* cpsv:
- revert "cpsv: use sv.current symlink as source"
- use sv.src symlink as source for runscript
* runit.preinst:
- fix wrong target for sv.current link
- create sv.src link to make cpsv source configurable
* trigger_sv:
- maintain a runtime copy of services in sv.now
- add a hook to atomically update services
- look both in /etc and /usr to enable a service,
/etc/sv/ is always preferred
* 40-runit: also test /usr/share/runit/sv.current
* update-service:
- look in /usr/ and /etc/ for services;
- stop requiring full path;
- prefer services in /etc/ over services in /usr:
* run_sysv_script: check /etc/service instead of /etc/sv
(Closes: #1022837)
* runit-init: drop obsolete Replaces without Breaks
* runit: duplicate triggers as mitigation for usrmerge.
+ Thanks to Helmut Grohne <hel...@subdivi.de>
(Closes: #1043419)
* d/rules: fix FTBFS after successful build
(Closes: #1046998)
Checksums-Sha1:
3506b9c7b9dc53f4c7045b8a711bcaf913574701 2294 runit_2.1.2-56.dsc
cb9e2ada88eaf8a30dc1a7cc4027f5c941d3cc02 63788 runit_2.1.2-56.debian.tar.xz
e8567e812ede0f8de649e2e53738a5395796132a 7563 runit_2.1.2-56_source.buildinfo
Checksums-Sha256:
13d17533e9939a7b60bc1d472a46e000004a584590f73fa8b7a1ec12c87b723f 2294
runit_2.1.2-56.dsc
89988862057a742de1a286b049aeec9a8e9b44b65fae2ded956859a063818e32 63788
runit_2.1.2-56.debian.tar.xz
08c61f08a4af8e805e0e605a4587e4b6d329b356a3058b7105698781df7761bc 7563
runit_2.1.2-56_source.buildinfo
Files:
f01723506586b3509c5bd452e423f2fe 2294 admin optional runit_2.1.2-56.dsc
6c121e0fd7b6b61018043bc190110b87 63788 admin optional
runit_2.1.2-56.debian.tar.xz
84c6c408ee1dd7e4e250cc71e56f86b4 7563 admin optional
runit_2.1.2-56_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEXHq+og+GMEWcyMi14n8s+EWML6QFAmTkspcACgkQ4n8s+EWM
L6Sunw//fRm4CPQ+f6cOl6VvKKj3A9WXY1T6Mr8s1JgCCzRpsWTNWnx2S2qL72A7
btLJgnHAd/xOQYH6OMj2yYrjMeuQx0KfW4R+viN0qFvwnl2jU5DdBQCCSfsxCD6S
ojOOKy4OmQFEtnoL91vLHb5q5B3KHj/6F4/alzuFChtLoLUCxolrPC+AxN/mjM4F
nikeTF991aqHwlqtq9aun5k1CEeMZZG4L8rgnJm74HtculRC5jf+rugVyL4vO4N5
WJyBiVAcL5FT2uUtL/bl2RE39JsU2vLoQcCPF4wdQB+72WCBj85vq224LLI4PZhA
W/YRqRroPAA1N6kDyyMTosI9SjF1ggmZ9wHqd2zcHpE21zroeMhU+4ex1MoguISg
eIFN453v8+iDD0rULi+VvdELNztlhu6bA/612t49SmWZT43NiO9Tp90Ph1NrMaGB
zHmqk1Sq3aTRDdyRn0C6foLeFrRFf/se5DXUNNEEZphMQOBzgMr6R2quDjfpqNGs
p0PsdbgIX/e04ir+dFkEoEP7ZmQ5+BuJ8GyVD9Bf+br7NSiPYz62OrsSDe5jyFpg
RVZc6nP5JXCFNqyEy6xxPkvrsd0xS95K9UyXVH4Y/PGq3FaF5dfT/roa1YITbzBi
lRiKTGMvdnLX3g7CrhgGp372rJqBv4u9ohMa6Hdp1tXCwT1o8nQ=
=SUHg
-----END PGP SIGNATURE-----
--- End Message ---
