Your message dated Fri, 24 Feb 2023 08:34:09 +0000
with message-id <e1pvtwr-005vhq...@fasolo.debian.org>
and subject line Bug#1024244: fixed in highway 1.0.3-3
has caused the Debian Bug report #1024244,
regarding highway FTCBFS: multiple reasons
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1024244: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1024244
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: highway
Version: 1.0.3~git20221102.4899d11-2
Tags: patch
User: debian-cr...@lists.debian.org
Usertags: ftcbfs
highway fails to cross build from source for multiple reasons. The
immediate failure is forcing a build architecture compiler by exporting
the make defaults for CC and CXX. Those values are wrong for cross
compilation and seeding them from dpkg's buildtools.mk is the easiest
way to fix that without overriding user choices. Next is failure to run
tests despite DEB_BUILD_OPTIONS containing nocheck. I'm attaching a
patch fixing both of these for your convenience. It also fixes some
build vs host confusions to fix specific cross build combinations.
Helmut
diff --minimal -Nru highway-1.0.3~git20221102.4899d11/debian/changelog
highway-1.0.3~git20221102.4899d11/debian/changelog
--- highway-1.0.3~git20221102.4899d11/debian/changelog 2022-11-03
12:50:53.000000000 +0100
+++ highway-1.0.3~git20221102.4899d11/debian/changelog 2022-11-14
14:17:59.000000000 +0100
@@ -1,3 +1,13 @@
+highway (1.0.3~git20221102.4899d11-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Honour DEB_BUILD_OPTIONS=nocheck.
+ + Default CC to a cross compiler via buildtools.mk.
+ * Fix a pile of build vs host confusions.
+
+ -- Helmut Grohne <hel...@subdivi.de> Mon, 14 Nov 2022 14:17:59 +0100
+
highway (1.0.3~git20221102.4899d11-2) experimental; urgency=medium
* d/patches: Fix atomic support
diff --minimal -Nru highway-1.0.3~git20221102.4899d11/debian/rules
highway-1.0.3~git20221102.4899d11/debian/rules
--- highway-1.0.3~git20221102.4899d11/debian/rules 2022-11-03
12:49:30.000000000 +0100
+++ highway-1.0.3~git20221102.4899d11/debian/rules 2022-11-14
14:17:59.000000000 +0100
@@ -12,19 +12,21 @@
# Let's pretend to know what we are doing:
DEB_CXXFLAGS_MAINT_APPEND += -DHWY_BROKEN_EMU128=0
-ifneq (,$(filter $(DEB_BUILD_ARCH), armhf armel))
+ifneq (,$(filter $(DEB_HOST_ARCH), armhf armel))
# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77728
DEB_CXXFLAGS_MAINT_APPEND += -Wno-psabi
endif
-ifeq ($(DEB_BUILD_ARCH),$(filter $(DEB_BUILD_ARCH),armhf))
+ifeq ($(DEB_HOST_ARCH),$(filter $(DEB_HOST_ARCH),armhf))
# highway implement dynamic dipatch:
# https://github.com/google/highway/issues/891
CMAKE_EXTRA_FLAGS += -DHWY_CMAKE_ARM7:BOOL=ON
endif
+include /usr/share/dpkg/buildtools.mk
+
# HWY_RVV requires `-march=rv64gcv1p0 -menable-experimental-extensions`
-ifeq ($(DEB_BUILD_ARCH),$(filter $(DEB_BUILD_ARCH),riscv64))
+ifeq ($(DEB_HOST_ARCH),$(filter $(DEB_HOST_ARCH),riscv64))
CC=clang
CXX=clang++
endif
@@ -39,10 +41,14 @@
-DBUILD_SHARED_LIBS:BOOL=ON \
-DHWY_WARNINGS_ARE_ERRORS:BOOL=ON \
-DHWY_SYSTEM_GTEST:BOOL=ON
+ifneq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
+CMAKE_EXTRA_FLAGS += -DBUILD_TESTING=OFF
+endif
override_dh_auto_configure-arch:
dh_auto_configure -- $(CMAKE_EXTRA_FLAGS)
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
# run default example to check compilation ok:
override_dh_install-arch:
ifeq (,$(filter $(DEB_BUILD_ARCH),hurd-i386))
@@ -51,6 +57,7 @@
echo "CPU 'QEMU Virtual CPU version 2.5+' does not support RDTSCP,
skipping benchmark."
endif
dh_install
+endif
override_dh_clean-indep:
dh_clean debian_docs/
--- End Message ---
--- Begin Message ---
Source: highway
Source-Version: 1.0.3-3
Done: Mathieu Malaterre <ma...@debian.org>
We believe that the bug you reported is fixed in the latest version of
highway, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1024...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mathieu Malaterre <ma...@debian.org> (supplier of updated highway package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 24 Feb 2023 08:52:20 +0100
Source: highway
Architecture: source
Version: 1.0.3-3
Distribution: unstable
Urgency: medium
Maintainer: Debian PhotoTools Maintainers
<pkg-phototools-de...@lists.alioth.debian.org>
Changed-By: Mathieu Malaterre <ma...@debian.org>
Closes: 1024244
Changes:
highway (1.0.3-3) unstable; urgency=medium
.
[ Helmut Grohne ]
* Fix FTCBFS: (Closes: #1024244)
* Fix a pile of build vs host confusions.
Checksums-Sha1:
2e1299ccdd82572ce2ad490e3530217f1832f208 2142 highway_1.0.3-3.dsc
972edfa6dac63f02facfbb55a1bdbcad95b22b1e 7868 highway_1.0.3-3.debian.tar.xz
13e99d3b60a95975ce52721bbf0412da19547c4c 7101 highway_1.0.3-3_source.buildinfo
Checksums-Sha256:
6a11d6188d1fe6c5f5717f26bec1a5bbb54dd09c8ec5c5952f7dae253658ee1a 2142
highway_1.0.3-3.dsc
b38a4355bc9305accba5134718d1c11e9c48ac8cc55487f726c04926fb866537 7868
highway_1.0.3-3.debian.tar.xz
bdda01b2ccecaabd7bdc9c9cd065f23714038357ea7c1240a2d5d50f5867c1e0 7101
highway_1.0.3-3_source.buildinfo
Files:
0b4c7b9077f16ee93514ff6cae0e769a 2142 libs optional highway_1.0.3-3.dsc
3a3cf3bb31550c1ef1d16041b9faaca4 7868 libs optional
highway_1.0.3-3.debian.tar.xz
14f655290a9050bf303fe169574e2cf3 7101 libs optional
highway_1.0.3-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEEaTNn/67NjqrNHwY7AXHhgorgk0UFAmP4bPMRHG1hbGF0QGRl
Ymlhbi5vcmcACgkQAXHhgorgk0VDhg/+JlFjlZdg9v8IB8rculhzJXumsgPAUqGS
Gq5iMGnxX6AmcYokutxH8MXAZ8TS23fg2Z+hf/7/0oL2D3oKHZmnbxEZm/yeJcoO
vLW1wRIfy3ss1qZp+DopxBYWoehku5nBOzBjSaZeYl7rXn0+piEvvnUnonu1bwZv
0ZCQFcXuGq3N03M+TTHNG+LtcL2ojcomQvDWLZLV8tIbGKOrj+sCY60szykUfrKo
IILcp/nsXD7trEVu/4Oa8fbqO0Is5rDQX5pYBCkGBQJ0FaknqFmwp8mTEeGbQxEs
QouUMxJLScS6GjNzoIhO4IQ78FDTPU3NNUfYDcBvUTytnWHnUHyszl2iCHvErqWT
flp8Tp1c4/D4ABJa1Q1D65wXK/ka8mvR+FA9enIEfO5gDjf3rlIoc0uD17vAxjF3
N79M1uW3QoeYKotVqWJEmrLVsNP51kXR7uH7UcH+euV9QL3XM6XRqfAOaIdCJjoi
PY30FPS1J53aH0J/5pj51gYVrovJcV91rBscqmuvh7IWNrzie6hXRO9qe0fGJIjx
qIPrStlSIeqQX9YjH+/KxmjM1BRjWQOPcBiXHlJdWgQOpqd2hjOu8Rh8aqrDVlyz
THMKq5gZhphkDOtTDMSbnqzX6QyjPtX3C4NZWMx7R+dMfxChbcpSpty0heqPPYmR
+2C4v2qqO/s=
=tTD8
-----END PGP SIGNATURE-----
--- End Message ---
