Your message dated Sun, 15 Jan 2023 00:09:03 +0000
with message-id <e1pgqa7-0076n5...@fasolo.debian.org>
and subject line Bug#1017847: fixed in thinkfan 1.3.1-3
has caused the Debian Bug report #1017847,
regarding thinkfan: ftbfs on riscv64(" undefined reference to 
`__atomic_fetch_sub_1'")
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1017847: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017847
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: thinkfan
Version: 1.3.1-2
Severity: normal
Tags: ftbfs, patch
User: debian-ri...@lists.debian.org
Usertags: riscv64
X-Debbugs-Cc: debian-ri...@lists.debian.org

Dear thinkfan Maintainer,

The thinkfan package has a ftbfs issue due to missing link
libatomic:

/usr/bin/cmake -E cmake_link_script CMakeFiles/thinkfan.dir/link.txt --verbose=1
/usr/bin/c++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wl,-z,relro -rdynamic 
CMakeFiles/thinkfan.dir/src/thinkfan.cpp.o 
CMakeFiles/thinkfan.dir/src/config.cpp.o CMakeFiles/thinkfan.dir/src/fans.cpp.o 
CMakeFiles/thinkfan.dir/src/sensors.cpp.o 
CMakeFiles/thinkfan.dir/src/message.cpp.o 
CMakeFiles/thinkfan.dir/src/parser.cpp.o 
CMakeFiles/thinkfan.dir/src/error.cpp.o 
CMakeFiles/thinkfan.dir/src/yamlconfig.cpp.o -o thinkfan  -lpthread -latasmart 
-ldl -lyaml-cpp
/usr/bin/ld: CMakeFiles/thinkfan.dir/src/thinkfan.cpp.o: in function 
`__gnu_cxx::__enable_if<std::__is_scalar<float>::__value, void>::__type 
std::__fill_a1<float*, float>(float*, float*, float const&)':
/usr/include/c++/11/bits/stl_algobase.h:924: undefined reference to 
`__atomic_fetch_sub_1'

The full buildd log is here:
https://buildd.debian.org/status/fetch.php?pkg=thinkfan&arch=riscv64&ver=1.3.1-2&stamp=1655545228&raw=0

The patch attached is trying to fix the issue and it is build ok on my
locally real riscv64 hardware, so could you apply it in the next upload
time?

please let me know if there are any issues.

-- 
Regards,
--
  Bo YU

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -108,6 +108,11 @@
 	target_link_libraries(thinkfan PRIVATE ${YAML_CPP_LIBRARIES})
 endif(USE_YAML)
 
+if(${CMAKE_SYSTEM_PROCESSOR} STREQUAL "riscv64")
+    target_link_libraries(thinkfan PRIVATE -latomic)
+endif()
+
+
 if(SYSTEMD_FOUND)
 	target_compile_definitions(thinkfan PRIVATE -DHAVE_SYSTEMD)
 endif()

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: thinkfan
Source-Version: 1.3.1-3
Done: Lee Garrett <deb...@rocketjump.eu>

We believe that the bug you reported is fixed in the latest version of
thinkfan, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1017...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Lee Garrett <deb...@rocketjump.eu> (supplier of updated thinkfan package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 15 Jan 2023 00:07:35 +0100
Source: thinkfan
Architecture: source
Version: 1.3.1-3
Distribution: unstable
Urgency: medium
Maintainer: Lee Garrett <deb...@rocketjump.eu>
Changed-By: Lee Garrett <deb...@rocketjump.eu>
Closes: 1017847
Changes:
 thinkfan (1.3.1-3) unstable; urgency=medium
 .
   * Remove path from md5sum call
   * d/control: Bump Standards-Version (no changes needed)
   * d/rules: Enable hardening build flags
   * Fix section in man page header
   * Add more lintian overrides
   * Fix FTBFS on RISC-V (Closes: #1017847)
   * d/control: We don't need root to build
   * Update d/copyright
   * Patch systemd unit to have Documentation key
   * Add dep3 headers to all patches
Checksums-Sha1:
 784b3f685ba576ef7c6bd20c6d0379950d59e619 2579 thinkfan_1.3.1-3.dsc
 d40890bce8a8498b0a24d67e8b28b75571fe8e61 9168 thinkfan_1.3.1-3.debian.tar.xz
 af9f0e688896ce85db5e1849bfa070e29eaae2b3 8487 thinkfan_1.3.1-3_amd64.buildinfo
Checksums-Sha256:
 ecfc95eae8d5913717890cb66deae55377300555763ed947321a0ca1a7cd653a 2579 
thinkfan_1.3.1-3.dsc
 810d878d1963eb0970e9b7ec6841d3fdb04b2268af46e5dc223692f00cc32459 9168 
thinkfan_1.3.1-3.debian.tar.xz
 e5d8db864942ce6e693a86de1f08ed8ae9073ca683f24e471bf3edb6e0a698c4 8487 
thinkfan_1.3.1-3_amd64.buildinfo
Files:
 9d4d567512c88f20a3be672988ca81f0 2579 misc optional thinkfan_1.3.1-3.dsc
 b25a93abd1c59ce9233e5e0894ab6a57 9168 misc optional 
thinkfan_1.3.1-3.debian.tar.xz
 e3cb5952b8623e1711047203517c1386 8487 misc optional 
thinkfan_1.3.1-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQQzBAEBCgAdFiEE2EfGJRCpwv8kLOAs1gShxII+4PgFAmPDOUcACgkQ1gShxII+
4Pis1h/7BJd4dP9E5hl/TGmNOoLDHTV2MoxhnjdcCFgNLcil1kqaqluDFvGmXb3W
2D/h16X1y1JSHBt06KW3/g3U04bXthrlgfz3gJLN2FOKbY4hwSG+IKhZ3AKdXZVi
HgqiMFp06k/3Fl86Zw2b8gCHldnONsR9Ns8Ls+7kOUXMwbRzoDCWRDYE3paFM8AH
FA/8Phr1ZkOOPT2rC9aGnrkVJ+IIAxxicYe13mQuv2o0KZlK4qaSWohZ2f7UD32O
dt5lWAybQd4Va3AzMkiabcRWJ+3jQ7IhgccwrNFf5Pqwbc1Ppj2NxQpnknchx33r
KWpMuGcS6xxOSAkC0IofMjOA5xSHHfI/ADFt9kk5wPyabOlsmYFQcKkbzYieK/0J
RYusGq+Qi8BelbA7ozVLyoWqAh9LL8MAK3TkfSszeEu5e0pckltfcdo2gn3whPKK
N5DoFg+Us5OmiKJpMqzxCEfEuxXX1yLUuO3WiSN177Pt/bHYWbaL3VBY1+1sxT4d
ygFQkQH1cPlojv+recPOQ2aPhaYtyXq7qmy3OGOnztTBESMlp4T/WP2sXEHVECoT
gn/N6a+9vEZZjkMHfCTkKOYYYqr4rYfIx3PPKvn/A1/ZFpKdzc8G2HWJKcITh+wL
fKYNzP1jm4zwpXcVnfRYmHAZMLBK24Xdh2fsU+IJG3DbGUy/TNFpAgTVuQKVsNVX
Or4dMUf8ejNGuZPCWGssC+W3/MZL6jOkuch4ErKMR8q0Wg1uh6d/YwCx8gWRa/S9
6nHVC9r6gsxcWRMtrVpbDHQk06BOJWOcPLyXj/tl7Sf3qzIv2rdyIKPKNq7EUjmk
s5YHSLJnlnRuBkuI57JxUGa2+3cJ2vr6EvE3WjQm6KUtzFrOQEe/UWlHzpe9W4jw
p57Cr9uCH9r50EmTwGKSSpTSw6+Xevr4A7RA9bMvOVl9vazWSpqgnackB2Q/K+HX
e6uLZOE2m+L4Q1/Vrv+VaJEu1OBvWawtiqMbLS/O0eY7Cb0X8VwRMoEcgsjHFmJP
Shy/QiIEwpr3XnXaa0/O2r1FihZS/6LOCdQRJT5+pbqvqSuB+AbIgeULZBfgaF4m
NpanAboxxq1iXQmNk2QpZZ3/Mu9jVhpqeH88VziTMD1KKmAOsL9hFyFdE2uGRY31
q0FYYbEvBrJIYC7i3FVBauekZrlhJMt3EhaqNNcvBkw/XryUpF/OYl8ij4c8xGeO
WCURO/DONb1REch2FqzjQFD8AfBKLAygbOvkBs8+Ghnn/tCKP6IogZHROTl6sPaC
NVZlyuPMF5OHgC5HenMTyOHVDdTTGabv4p1OjIEhDwXnQDlv93uG649zCwiz73iJ
lN/RLAnZSysLdvTs5b1YsuRqu/HWDQ==
=nMO5
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to