Your message dated Thu, 05 Jan 2023 13:35:08 +0000
with message-id <e1pdqoi-007ah6...@fasolo.debian.org>
and subject line Bug#1024635: fixed in dash 0.5.12-2
has caused the Debian Bug report #1024635,
regarding dash: segfaults during runtime when executing a script with invalid 
syntax
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1024635: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1024635
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: dash
Version: 0.5.11+git20210903+057cd650a4ed-9
Severity: normal
Tags: upstream
Control: forwarded -1 
https://lore.kernel.org/dash/b2e298215b3d51d8284296484caa138faddaa0e4.ca...@scientia.org/


Hey.

I've already forwarded this upstream, but there doesn't seem to be any
bug tracker, so report it here in addition, to keep some records until
it is fixed.


Cheers,
Chris.



I found the following issue by chance, when converting a shell
script[0] from bash to POSIX sh (well that + the use of "local"):

Below is a strongly reduced version of [0] which still causes the
error:
-------------------------------------------------------------------
#!/bin/sh


reject_and_die()
{
    exit 1
}


reject_filtered_cmd()
{
    reject_and_die "disallowed command${restrict_path_list:+ (restrict-path: 
\"${restrict_path_list//|/\", \"}\")}"
}

reject_filtered_cmd
-------------------------------------------------------------------

As you can see, I missed one bashism, namely the
${parameter//pattern/string} form of parameter expansion.


Now executing this with dash:
$ dpkg -l dash | grep ^ii
ii  dash           0.5.11+git20210903+057cd650a4ed-9 amd64        
POSIX-compliant shell
$ dash ssh_filter_btrbk.sh
Segmentation fault
$

With kernel log:
Nov 21 03:31:37 heisenberg kernel: dash[145217]: segfault at 1 ip 
000055fa32ef8cd4 sp 00007ffd79a75140 error 4 in dash[55fa32ef3000+13000]
Nov 21 03:31:37 heisenberg kernel: Code: e2 01 4c 8d 34 42 48 8d 05 61 d9 00 00 
49 01 c6 89 f0 83 e0 02 89 85 fc fe ff ff 74 17 c7 85 fc fe ff ff 00 00 00 00 
83 e3 fd <41> 80 3f 7e 0f 84 c2 05 00 00 48 8b 35 8b 58 01 00 48 8b 05 5c 53


Shouldn't that rather give some parsing error?



One some other system (where I cannot really test any further since I
have no root) it even may have caused some more:
[10527194.157467] ssh_filter_btrb[816610]: segfault at 0 ip 000055c8ac34a698 sp 
00007ffd4a997080 error 4 in dash[55c8ac344000+13000]
[10527194.157482] Code: 85 c4 01 00 00 48 83 c4 68 4c 89 f8 5b 5d 41 5c 41 5d 
41 5e 41 5f c3 0f 1f 00 48 83 c2 02 eb a2 66 90 4c 89 fa 4d 85 f6 78 98 <48> 8b 
36 bf 01 00 00 00 eb 8e 66 0f 1f 44 00 00 0f b6 42 01 48 83
[10527195.790531] traps: pool-tracker-st[816482] trap int3 ip:7f94e8271295 
sp:7f94deffc770 error:0 in libglib-2.0.so.0.6400.6[7f94e8235000+84000]

Not sure whether that traps is in anyway related or just some
coincidence.



Thanks,
Chris.


[0] https://github.com/digint/btrbk/blob/master/ssh_filter_btrbk.sh

--- End Message ---
--- Begin Message ---
Source: dash
Source-Version: 0.5.12-2
Done: Andrej Shadura <andre...@debian.org>

We believe that the bug you reported is fixed in the latest version of
dash, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1024...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andrej Shadura <andre...@debian.org> (supplier of updated dash package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 05 Jan 2023 14:20:48 +0100
Source: dash
Architecture: source
Version: 0.5.12-2
Distribution: unstable
Urgency: medium
Maintainer: Andrej Shadura <andre...@debian.org>
Changed-By: Andrej Shadura <andre...@debian.org>
Closes: 558607 819829 975325 975326 1017531 1024635
Changes:
 dash (0.5.12-2) unstable; urgency=medium
 .
   * Fix the changelog entry.
 .
 dash (0.5.12-1) unstable; urgency=medium
 .
   * New upstream release (Closes: #1017531, #1024635).
   * Refresh patches.
   * Apply upstream patches for hash, ulimit and manpages
     (Closes: #558607, #819829, #975325, #975326).
Checksums-Sha1:
 fa572b2b5f629af9618ea08693bb83b93a4cba7a 1520 dash_0.5.12-2.dsc
 3d892a207a28afa4894296c76c0a3c322b892a6a 38512 dash_0.5.12-2.debian.tar.xz
Checksums-Sha256:
 25c0fb805c735fdb7470ce485ce76dae1a7b6c04efdfb0fdac5eab921cbd78a5 1520 
dash_0.5.12-2.dsc
 bddd9129215eb60f4cc43a0ffdcc42d8f25e0bd09730520d599a2b7bc492e375 38512 
dash_0.5.12-2.debian.tar.xz
Files:
 c9bc18de18ef1473455b481ab1a8ede1 1520 shells optional dash_0.5.12-2.dsc
 54efe6439b0ddae0eef83f6635609371 38512 shells optional 
dash_0.5.12-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQSD3NF/RLIsyDZW7aHoRGtKyMdyYQUCY7bPAgAKCRDoRGtKyMdy
YUbYAP9x9er7SC0J4zeO9pEB6EC9zxkn/7M+RsJKGxvaOThO5AEA5wu2PSI1YsM3
2cEheyy8EPzWh7FhHyJ+o01jXk8WKgg=
=FOGH
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to